Skip to content

bump jsonpath-plus minimum version to 10.3.0 #2265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kevinthenet
Copy link
Contributor

@kevinthenet kevinthenet commented Feb 24, 2025

Resolves vulnerability reported by Snyk.

For any new installations this should pick up 10.3.0, but this change ensures there's no risk of installing any problematic versions.

  • npm test passes
  • npm run generate yields no errors

Copy link

linux-foundation-easycla bot commented Feb 24, 2025

CLA Signed


The committers listed above are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

Welcome @kevinthenet!

It looks like this is your first PR to kubernetes-client/javascript 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/javascript has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 24, 2025
@brendandburns
Copy link
Contributor

/lgtm
/approve

I wonder why @dependabot didn't send a PR for this.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 24, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, kevinthenet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2025
@k8s-ci-robot k8s-ci-robot merged commit 42f8270 into kubernetes-client:main Feb 24, 2025
7 of 8 checks passed
@kevinthenet
Copy link
Contributor Author

@brendandburns

I wonder why @dependabot didn't send a PR for this.

I recall seeing a PR/commit of the sort before v1.x, but I think the file regressed or was undone by another PR. In any case, it would be nice if we could cherry-pick this commit to the 0.22.3 tag so folks that haven't upgraded to 1.x have the vulnerability saved as well, though I'm not sure if you're still supporting 0.22.x.

Happy to pitch in if needed.

@cjihrig
Copy link
Contributor

cjihrig commented Feb 24, 2025

It was bumped by dependabot in #2236.

@b96m
Copy link

b96m commented Mar 3, 2025

would greatly appreciate a patch release for this on the 1.0.x track as soon as possible, multiple internal auditing tools have this as a critical severity

@b96m
Copy link

b96m commented Mar 10, 2025

would greatly appreciate a patch release for this on the 1.0.x track as soon as possible, multiple internal auditing tools have this as a critical severity

bump on this, would really appreciate a patch, can help as needed @cjihrig @brendandburns

@cjihrig
Copy link
Contributor

cjihrig commented Mar 10, 2025

There is a v1.1.0 pending, although I don't know the exact timeline for a release.

@b96m
Copy link

b96m commented Mar 18, 2025

There is a v1.1.0 pending, although I don't know the exact timeline for a release.

@cjihrig any way we can get a 1.0.1 or similar patch release for this? Security scanning tooling is freaking out about this issue

@cjihrig
Copy link
Contributor

cjihrig commented Mar 18, 2025

It looks like v1.1.0 was released a few days ago.

@b96m
Copy link

b96m commented Mar 18, 2025

It looks like v1.1.0 was released a few days ago.

oh nice thanks for letting me know, I don't see a tag for it in GitHub but I do see the NPM release. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants