Skip to content

Commit a7126fa

Browse files
committed
Cleaned up JSONArray iterator
1 parent 911becf commit a7126fa

File tree

1 file changed

+13
-14
lines changed

1 file changed

+13
-14
lines changed

src/javaxt/orm/Model.java

+13-14
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
public class Model {
1515

1616
private String name;
17-
private HashSet<String> implementations;
17+
private TreeSet<String> implementations;
1818
private ArrayList<Field> fields;
1919
private static final String template = getTemplate();
2020
private String tableName;
@@ -32,7 +32,7 @@ public class Model {
3232
*/
3333
protected Model(String modelName, JSONObject modelInfo, String packageName, HashMap<String, String> options){
3434
this.name = modelName;
35-
this.implementations = new HashSet<>();
35+
this.implementations = new TreeSet<>();
3636
this.fields = new ArrayList<>();
3737
this.options = options;
3838
this.packageName = packageName;
@@ -207,7 +207,7 @@ public String getJavaCode(){
207207
StringBuilder hasMany = new StringBuilder();
208208
StringBuilder initArrays = new StringBuilder();
209209
String getLastModified = "";
210-
java.util.TreeSet<String> includes = new java.util.TreeSet<>();
210+
TreeSet<String> includes = new TreeSet<>();
211211

212212

213213
for (int i=0; i<fields.size(); i++){
@@ -599,15 +599,14 @@ else if (fieldType.equals("byte[]")){
599599
getJson.append(" if (json.has(\"");
600600
getJson.append(fieldName);
601601
getJson.append("\")){\r\n");
602-
getJson.append(" JSONArray _");
602+
getJson.append(" for (JSONValue _");
603603
getJson.append(fieldName);
604-
getJson.append(" = json.get(\"");
604+
getJson.append(" : json.get(\"");
605605
getJson.append(fieldName);
606-
getJson.append("\").toJSONArray();\r\n");
607-
getJson.append(" for (int i=0; i<_" + fieldName + ".length(); i++){\r\n");
606+
getJson.append("\").toJSONArray()){\r\n");
608607
getJson.append(" ");
609608
getJson.append(fieldName);
610-
getJson.append(".add(new " + modelName + "(_" + fieldName + ".get(i).toJSONObject()));\r\n");
609+
getJson.append(".add(new " + modelName + "(_" + fieldName + ".toJSONObject()));\r\n");
611610
getJson.append(" }\r\n");
612611
getJson.append(" }\r\n\r\n");
613612
}
@@ -759,8 +758,8 @@ public String getTableSQL(){
759758

760759

761760
//Add fields
762-
java.util.ArrayList<String> foreignKeys = new java.util.ArrayList<>();
763-
java.util.Iterator<Field> it = fields.iterator();
761+
ArrayList<String> foreignKeys = new ArrayList<>();
762+
Iterator<Field> it = fields.iterator();
764763
while (it.hasNext()){
765764
Field field = it.next();
766765
if (field.isArray()) continue;
@@ -823,7 +822,7 @@ public String getTableSQL(){
823822
*/
824823
public String getDiamondTableSQL(){
825824
StringBuilder str = new StringBuilder();
826-
java.util.Iterator<Field> it = fields.iterator();
825+
Iterator<Field> it = fields.iterator();
827826
while (it.hasNext()){
828827
Field field = it.next();
829828
if (field.isArray()){
@@ -925,7 +924,7 @@ public String getDiamondTableSQL(){
925924
*/
926925
public String getForeignKeySQL(){
927926
StringBuilder str = new StringBuilder();
928-
java.util.Iterator<Field> it = fields.iterator();
927+
Iterator<Field> it = fields.iterator();
929928
while (it.hasNext()){
930929
Field field = it.next();
931930
if (!field.isArray()){
@@ -967,7 +966,7 @@ public String getForeignKeySQL(){
967966
public String getIndexSQL(){
968967
StringBuilder str = new StringBuilder();
969968
String indexPrefix = "IDX_" + tableName.toUpperCase()+ "_";
970-
java.util.Iterator<Field> it = fields.iterator();
969+
Iterator<Field> it = fields.iterator();
971970
while (it.hasNext()){
972971
Field field = it.next();
973972
if (!field.isArray()){
@@ -1036,7 +1035,7 @@ public String getTriggerSQL(){
10361035
/** Returns true if the model contains a lastModified date field.
10371036
*/
10381037
protected boolean hasLastModifiedField(){
1039-
java.util.Iterator<Field> it = fields.iterator();
1038+
Iterator<Field> it = fields.iterator();
10401039
while (it.hasNext()){
10411040
Field field = it.next();
10421041
if (field.isArray()) continue;

0 commit comments

Comments
 (0)