Skip to content

Sync with upstream @ ef8d5768 #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 100 commits into from
Aug 3, 2021
Merged

Sync with upstream @ ef8d5768 #161

merged 100 commits into from
Aug 3, 2021

Conversation

javascript-translate-bot
Copy link
Contributor

This PR was automatically generated to merge changes from en.javascript.info at ef8d576

Conflicted files in this PR have labels ">>>..." with both sides of conflict. If you merge this PR, you'll need to examine the listed files and resolve conflicts.

Alternatively, you can close this PR and merge conflicting changes manually.

The following files have conflicts and may need updates of the translations:

To merge changes manually (instead of merging this PR):

  1. Add remote upstream that links to the English version (only needs to be done once)
    • git add remote upstream https://github.com/javascript-tutorial/en.javascript.info
  2. Commit all current work locally and git checkout master
  3. Pull the recent changes from the English version:
    • git pull upstream master
  4. Deal with the conflicts. If a conflict touches a few lines, then just fix it. Otherwise, following commands can help:
    • Checkout your (translated) version of a file/folder at the given path (removes all upstream changes):
      • git checkout --ours <path>
    • See the diff, what changed in the upstream file since branches diverged:
      • git diff --word-diff master...upstream/master <path> (please note: three dots in the command)
    • Then you can examine the changes in upstream and add them manually
  5. When conflicts resolved, commit them and git push origin master

This PR will be closed and replaced with a new one in a few days.

joaquinelio and others added 30 commits March 28, 2021 00:08
"inserts into" instead of "appends to"
Removed unnecessary escape characters from regex in "getCookie function in cookie.js" - 
. ( ) [ / +
The above characters don't need escaping.
Unnecessary escape characters in cookie.js
…rties-methods

It looks like code was changed some time ago, but comments didn't change accordingly.
minor edit to 1-js/05-data-types/02-number/
slightly improve clarity of Promise.all()
@CLAassistant
Copy link

CLAassistant commented Jul 28, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
4 out of 11 committers have signed the CLA.

✅ iliakan
✅ joaquinelio
✅ mahdyar
✅ tarasyyyk
❌ ZYinMD
❌ NNboru
❌ Yoona8
❌ Gammadon
❌ riri-yu
❌ WebSavva
❌ Manik2375
You have signed the CLA already but the status is still pending? Let us recheck it.

@tarasyyyk tarasyyyk merged commit 5bc7188 into master Aug 3, 2021
@tarasyyyk tarasyyyk deleted the sync-ef8d5768 branch August 3, 2021 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.