Skip to content

PR for issues/2119 #2121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 23, 2020
Merged

PR for issues/2119 #2121

merged 6 commits into from
Sep 23, 2020

Conversation

zzy0302
Copy link
Contributor

@zzy0302 zzy0302 commented Sep 17, 2020

issues2119

Sorry for my poor English and not good at markdown.

@CLAassistant
Copy link

CLAassistant commented Sep 17, 2020

CLA assistant check
All committers have signed the CLA.

Comment on lines 84 to 87
```smart header="Compatibility issues"
Right now `BigInt` is supported in Firefox/Chrome/Edge, but not in Safari/IE.
Right now `BigInt` is supported in the latest version Firefox/Chrome/Edge and Safari with iOS 14, but not in IE.
```
[More Details](https://caniuse.com/?search=bigint) about BigInt compatibility.
Copy link
Contributor

@MuhammedZakir MuhammedZakir Sep 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is no need to mention Safari's version, we don't mention it for others. If someone wants to know more, they can look it in MDN or caniuse. Also, link to caniuse should be inside code block.

Right now, `BigInt` is supported in Firefox/Chrome/Edge/Safari, but not in IE.

You can check [*Can I Use* BigInt compatibility table](https://caniuse.com/bigint) to know which versions of a browser are supported.

What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, simple is best, just do it.
This was my first time to have a pull request, thank you! XD

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, simple is best, just do it.

You can correct it and add it in a new commit. Or do you want me to do it? It's easy, though! :-)

This was my first time to have a pull request, thank you! XD

You are welcome! 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this done?
Thank you, friend ~

Co-authored-by: Muhammed Zakir <8190126+MuhammedZakir@users.noreply.github.com>
@iliakan iliakan merged commit 26505f3 into javascript-tutorial:master Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants