-
Notifications
You must be signed in to change notification settings - Fork 3.9k
PR for issues/2119 #2121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR for issues/2119 #2121
Conversation
Safari in iOS14 support BigInt
```smart header="Compatibility issues" | ||
Right now `BigInt` is supported in Firefox/Chrome/Edge, but not in Safari/IE. | ||
Right now `BigInt` is supported in the latest version Firefox/Chrome/Edge and Safari with iOS 14, but not in IE. | ||
``` | ||
[More Details](https://caniuse.com/?search=bigint) about BigInt compatibility. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is no need to mention Safari's version, we don't mention it for others. If someone wants to know more, they can look it in MDN or caniuse. Also, link to caniuse should be inside code block.
Right now, `BigInt` is supported in Firefox/Chrome/Edge/Safari, but not in IE.
You can check [*Can I Use* BigInt compatibility table](https://caniuse.com/bigint) to know which versions of a browser are supported.
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, simple is best, just do it.
This was my first time to have a pull request, thank you! XD
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, simple is best, just do it.
You can correct it and add it in a new commit. Or do you want me to do it? It's easy, though! :-)
This was my first time to have a pull request, thank you! XD
You are welcome! 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this done?
Thank you, friend ~
Co-authored-by: Muhammed Zakir <8190126+MuhammedZakir@users.noreply.github.com>
issues2119
Sorry for my poor English and not good at markdown.