Skip to content

minor #1794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

minor #1794

wants to merge 2 commits into from

Conversation

qucumbah
Copy link

No description provided.

@CLAassistant
Copy link

CLAassistant commented Mar 10, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@iliakan
Copy link
Member

iliakan commented Mar 21, 2020

Error? Why?

@qucumbah
Copy link
Author

if you execute the code it throws:
ReferenceError: Must call super constructor in derived class before accessing 'this' or returning from derived constructor
the description even says "Here’s an example of such code (it doesn’t work – why? fix it?)"

@iliakan iliakan closed this in 4357ba9 Mar 21, 2020
This was referenced Mar 21, 2020
Closed
Closed
iliakan added a commit that referenced this pull request Mar 22, 2020
@iliakan
closes #1794
6ec3f34
@iliakan
Copy link
Member

iliakan commented Mar 22, 2020

Right, thanks!

@iliakan
Copy link
Member

iliakan commented Mar 22, 2020

There was an error there indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qucumbah @CLAassistant @iliakan