-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Make minor grammar corrections/updates to async/promise-chaining #1661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All changes OK. I made a couple suggestions for pretty minor improvements.
@paroche should we merge it in its current state? |
Would be OK to merge as is. I had some small suggestions but they could be done later, or not at all. When you "assign" it to me, what exactly does that mean? |
@paroche that means I'm unable to resolve the matter, as it's not about JavaScript, but rather about the English language, the wording and the syntax. So I kindly ask you to take a look, request changes and merge if you deem appropriate :) |
OK. Just seems like you've asked me to look at things before without "assigning" them to me. I guess it's the "merge if I deem appropriate" part that might be different. Though with these more extensive changes where I agree with some, not with others, and for others might have a third (and/or forth) suggestion, I'm not sure how to proceed -- don't think I can push it piece-meal or make revisions (except after pushing it all). And may want to give the author of the PR a chance to make revisions or comments first. So then I just comment. |
@paroche you use create a review and "request changes" using the button in the right-upper corner, right? Then the PR author should review and update their PR. |
Updated |
OK. Too bad approving it piece-meal isn't an option (or doesn't seem to be). Seems like would be easier for long series of edits in one PR. |
Agreed. |
That was in response to Ilya's last comment, but I'm glad you agree. Is harder to keep track this way and it can lead to a lot of redundancy in reviewing changes. |
Split out and revised changes originally in #1612