Make minor grammar corrections/updates to async/callbacks #1659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lex111
approved these changes
Dec 19, 2019
paroche
requested changes
Dec 19, 2019
|
@paroche not merging it yet, waiting for changes, right? |
|
Well, I was making my opinions known. For the 4 where I commented on the commas, I would not merge them on my own, since I don't prefer them. The last one, line 306, w/ the "pyramid of doom", I would merge on its own, but don't recall seeing that as an option. |
|
I do not think commas should be used to indicate pauses in speech, nevertheless I have made the updates as requested. |
paroche
approved these changes
Jan 2, 2020
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first of the split out and revised changes originally in #1612