Skip to content

BigInt Type added in primitive types #1620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 30, 2019
Merged

BigInt Type added in primitive types #1620

merged 2 commits into from
Nov 30, 2019

Conversation

ajitsinghkaler
Copy link
Contributor

The new Bigint type was not added to the primitive types I added it to the primitive type please tell me where ever it needs to be added. So that the whole documentation is consistent everywhere.

@CLAassistant
Copy link

CLAassistant commented Nov 20, 2019

CLA assistant check
All committers have signed the CLA.

@ajitsinghkaler
Copy link
Contributor Author

BigInt is currently in stage 4 of approving and is just left to be shipped to Safari rest its applicable everywhere I think we should add it.

@iliakan
Copy link
Member

iliakan commented Nov 30, 2019

It's not in https://tc39.es/ecma262/ yet though

@iliakan iliakan closed this Nov 30, 2019
@iliakan iliakan reopened this Nov 30, 2019
@ajitsinghkaler
Copy link
Contributor Author

ajitsinghkaler commented Nov 30, 2019

It's there in it. That is why I posted it. It's already implemented in Chrome and Mozilla only Safari implementation is left. That too is going on.

@iliakan iliakan merged commit 438e66d into javascript-tutorial:master Nov 30, 2019
@iliakan
Copy link
Member

iliakan commented Nov 30, 2019

I shouldn't have accepted this PR. It's terrible. It ignores all the flow of the tutorial and just sticks BigInt where it shouldn't be.

@iliakan
Copy link
Member

iliakan commented Nov 30, 2019

and uses typeof operator even before it's explained.

@ajitsinghkaler
Copy link
Contributor Author

Please tell me how can I improve I didn't know in which firm you want this.

@iliakan
Copy link
Member

iliakan commented Nov 30, 2019

I will rewrite that. Just please look at the tutorial in future PRs, so that you don't use unexplained operators in your code. Our purpose is to explain things well, not just list them as the manual does.

@ajitsinghkaler
Copy link
Contributor Author

I've just started contribution to open source please forgive me this time I'll learn from the way you articulate your PR and terms I'm really sorry for this time. Thank you for for correcting my PR

@ajitsinghkaler ajitsinghkaler deleted the BigInt branch November 30, 2019 10:13
@iliakan
Copy link
Member

iliakan commented Nov 30, 2019

thank you for your efforts, surely you can do better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants