Skip to content

fix Jetty ALPN usage on newer OpenJDK releases #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2020
Merged

fix Jetty ALPN usage on newer OpenJDK releases #42

merged 1 commit into from
May 6, 2020

Conversation

Ladicek
Copy link
Contributor

@Ladicek Ladicek commented May 6, 2020

No description provided.

@Ladicek
Copy link
Contributor Author

Ladicek commented May 6, 2020

I couldn't figure out how to make this configuration apply for 8u252 and above, so at least this works for 8u252 itself.

@dmatej
Copy link
Contributor

dmatej commented May 6, 2020

Probably it could be resolved by some intelligent classloader providing one of possible jars on classpath, but it would take more time to implement it with disputable ugly result.

@arjantijms
Copy link
Contributor

Thanks again! :)

@arjantijms arjantijms merged commit 81d4b6b into javaee-samples:master May 6, 2020
@Ladicek Ladicek deleted the new-openjdk-alpn branch May 7, 2020 06:05
@Ladicek
Copy link
Contributor Author

Ladicek commented May 7, 2020

We could probably use the Jetty ALPN agent: https://github.com/jetty-project/jetty-alpn-agent Well, perhaps next time :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmatej dmatej dmatej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ladicek @dmatej @arjantijms