ci: build and publish javax flavour #522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'release' github action has a new job to build the javax flavour of this project. This job has three main steps: - Replace all the jakarta imports and dependencies with the javax ones - Downgrade springframework dependency to the version 5.* - Using jdk 11 to build the project and publish it The cold migration from jakarta to javax is done via a new bash script `.github/replaceJakartaWithJavax.sh` that uses mainly the sed command to perform the replacement operations. In gradle.properties the SOURCE_COMPATIBILITY and the TARGET_COMPATIBILITY constants are downgraded to 11 in order to allow the users to use the latest version of this library even in projects where the jdk11 is mandatory. Updated the README with a brief explanation of the difference between the two flavours of this project.
|
@federicorispo Could you merge the two snapshot workflows as well the same way you did with release? So that when a snapshot is published it also publishes one for |
|
@oliemansm no problem, I will do it! What about tags? For now there is only one tag for both flavours: is it ok for you? |
|
Yeah now that it's on one branch again that sounds ok 👍🏻 |
- Refactored bash scripts to accept only javax flavour - Removed snapshot-suffix.yml action - Added test-javax jobs in release action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'release' github action has a new job to build the javax flavour of this project. This job has three main steps:
The cold migration from jakarta to javax is done via a new bash script
.github/replaceJakartaWithJavax.shthat uses mainly the sed command to perform the replacement operations.In gradle.properties the SOURCE_COMPATIBILITY and the TARGET_COMPATIBILITY constants are downgraded to 11 in order to allow the users to use the latest version of this library even in projects where the jdk11 is mandatory.
Updated the README with a brief explanation of the difference between the two flavours of this project.