For non-async servlet wait until GraphQL async operation finished. #470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliemansm
approved these changes
Aug 16, 2022
|
@oliemansm can you release a hotfix? |
|
Yeah, will do that today. |
|
Thank you so much! |
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
We just upgraded to the latest version of https://github.com/graphql-java-kickstart/graphql-spring-boot/releases/tag/v13.0.0. And found that all of our tests failed.
The reason because we are not using a sync servlet, but our GraphQL partially uses common ForkJoinPool for fetching fields and the result is that the current HttpRequestInvokerImpl is not waiting for the result to be loaded.