Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/crypto
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.9.0
Choose a base ref
...
head repository: golang/crypto
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.11.0
Choose a head ref
  • 12 commits
  • 22 files changed
  • 7 contributors

Commits on Jun 5, 2023

  1. Add support for "hmac-sha2-512-etm@openssh.com"

    Change-Id: I0203881afd7ad72e68f76650817451d7e292c91b
    GitHub-Last-Rev: 42b4119
    GitHub-Pull-Request: #129
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/226982
    Run-TryBot: Han-Wen Nienhuys <hanwen@google.com>
    Reviewed-by: Han-Wen Nienhuys <hanwen@google.com>
    Auto-Submit: Han-Wen Nienhuys <hanwen@google.com>
    Reviewed-by: David Chase <drchase@google.com>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    s-k2 authored and gopherbot committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    1622238 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2023

  1. x509roots: add new module

    Adds the nss parser, under x509roots/nss, and the fallback
    module/package, with the initial generated bundle.
    
    Fixes golang/go#57792
    
    Change-Id: Iebb1052e49126fa5baba1236f4ebc8dd8a823179
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/462036
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Run-TryBot: Roland Shoemaker <roland@golang.org>
    Reviewed-by: Filippo Valsorda <filippo@golang.org>
    Reviewed-by: Damien Neil <dneil@google.com>
    Auto-Submit: Roland Shoemaker <roland@golang.org>
    rolandshoemaker authored and gopherbot committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    d0b3160 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2023

  1. go.mod: tell x repo tagging to ignore dep on net

    CL 475438 introduced a cycle between net and crypto. This direction is
    less important, so have the tagging process ignore it.
    
    Change-Id: Ie424fef0238702a5a16aba79bb60f86f39dc66eb
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/502595
    Auto-Submit: Heschi Kreinick <heschi@google.com>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Reviewed-by: Damien Neil <dneil@google.com>
    Run-TryBot: Heschi Kreinick <heschi@google.com>
    heschi authored and gopherbot committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    22c9997 View commit details
    Browse the repository at this point in the history
  2. go.mod: update golang.org/x dependencies

    Update golang.org/x dependencies to their latest tagged versions.
    Once this CL is submitted, and post-submit testing succeeds on all
    first-class ports across all supported Go versions, this repository
    will be tagged with its next minor version.
    
    Change-Id: If19e251a79af033583e6968766b7a831741cebb7
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/502518
    Reviewed-by: Heschi Kreinick <heschi@google.com>
    Run-TryBot: Gopher Robot <gobot@golang.org>
    Reviewed-by: Carlos Amedee <carlos@golang.org>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Auto-Submit: Gopher Robot <gobot@golang.org>
    gopherbot committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    8e447d8 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2023

  1. ssh/test: set a timeout and WaitDelay on sshd subcommands

    This uses a copy of testenv.Command copied from the main repo, with
    light edits to allow the testenv helpers to build with Go 1.19.
    
    The testenv helper revealed an exec.Command leak in TestCertLogin, so
    we also fix that leak and simplify server cleanup using
    testing.T.Cleanup.
    
    For golang/go#60099.
    Fixes golang/go#60343.
    
    Change-Id: I7f79fcdb559498b987ee7689972ac53b83870aaf
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/496935
    Auto-Submit: Bryan Mills <bcmills@google.com>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Reviewed-by: Roland Shoemaker <roland@golang.org>
    Run-TryBot: Bryan Mills <bcmills@google.com>
    Bryan C. Mills authored and gopherbot committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    0ff6005 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2023

  1. x509roots: use "generate" build tag

    Since go generate sets it automatically.
    
    Change-Id: I4623e523392140c0472b250ac99c8c3fa31e5b15
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/504595
    Auto-Submit: Roland Shoemaker <roland@golang.org>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
    Run-TryBot: Roland Shoemaker <roland@golang.org>
    rolandshoemaker authored and gopherbot committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    0d502d7 View commit details
    Browse the repository at this point in the history
  2. x509roots: fix generate script argument checking

    Check for supply of both arguments forgot that the URL is set by
    default. Instead just let the local path supersede the URL.
    
    Change-Id: I0499137c99c735e8e453ff1c2a925435f3cd8039
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/504596
    Run-TryBot: Roland Shoemaker <roland@golang.org>
    Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    Auto-Submit: Roland Shoemaker <roland@golang.org>
    rolandshoemaker authored and gopherbot committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    043e94c View commit details
    Browse the repository at this point in the history
  3. x509roots: remove list hash and generation date, change ordering

    This makes the automated update workflow simpler.
    
    Also switch the ordering from human readable subject (which is not
    necessarily unique), to the raw SPKI (which should always be unique).
    This makes it somewhat harder to read to a human (since it'll appear a
    little jumbled) but results in a stable sort.
    
    Note this results in adding two new roots, which were added since we
    last generated the bundle.
    
    Change-Id: Id4d34bf9e98164e7b2fc4f06f9b46b63c0013d23
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/504597
    Run-TryBot: Roland Shoemaker <roland@golang.org>
    Reviewed-by: Heschi Kreinick <heschi@google.com>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    rolandshoemaker committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    5fe8145 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2023

  1. ssh: add hmac-sha2-512

    This adds support for hmac-sha2-512 to ensure compatibility with SSH clients that request this MAC algorithm.
    
    This rebases #18.
    
    Change-Id: Ia103c10a8b7e2e8dde556d5c36550eb5fa6bc1f6
    GitHub-Last-Rev: 987ccae
    GitHub-Pull-Request: #257
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/501455
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    Commit-Queue: Han-Wen Nienhuys <hanwen@google.com>
    Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
    Reviewed-by: Han-Wen Nienhuys <hanwen@google.com>
    Run-TryBot: Han-Wen Nienhuys <hanwen@google.com>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    stanhu authored and gopherbot committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    64c3993 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2023

  1. x509roots/fallback: add //go:build go1.20 to bundle.go

    Package fallback has no API; its only purpose is to automatically call
    x509.SetFallbackRoots with a set of fallback roots. That API was added
    in Go 1.20, hence the go1.20 build constraint in fallback.go.
    
    Add that constraint to bundle.go too, so that it fails to build rather
    than quietly being a no-op in Go 1.19.
    
    Also simplify Write(fmt.Sprintf()) into fmt.Fprintf while here.
    
    Add a temporary workaround for go.dev/issue/52287.
    It has no effect on the public API in this module.
    
    For golang/go#57792.
    For golang/go#52287.
    
    Change-Id: I1fe13f7d54b07b0b031e8bae685cffd7a8160165
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/505578
    Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    Reviewed-by: Roland Shoemaker <roland@golang.org>
    Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
    dmitshur authored and gopherbot committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    a9e447d View commit details
    Browse the repository at this point in the history
  2. x509roots: generate a stable sort, for real this time

    Sort based on the stringified subject, then break ties based on the raw
    DER (which will, actually, be unique this time).
    
    Change-Id: I3dd912fb19b103e92fabfb4562e31c6dcec40614
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/505695
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Run-TryBot: Roland Shoemaker <roland@golang.org>
    rolandshoemaker committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    183630a View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2023

  1. go.mod: update golang.org/x dependencies

    Update golang.org/x dependencies to their latest tagged versions.
    Once this CL is submitted, and post-submit testing succeeds on all
    first-class ports across all supported Go versions, this repository
    will be tagged with its next minor version.
    
    Change-Id: Icede82501a3703fcaad524f6b91ff6e5452b4547
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/507837
    Reviewed-by: Heschi Kreinick <heschi@google.com>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    Run-TryBot: Gopher Robot <gobot@golang.org>
    Auto-Submit: Gopher Robot <gobot@golang.org>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    gopherbot committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    e984872 View commit details
    Browse the repository at this point in the history
Loading