Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/crypto
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.4.0
Choose a base ref
...
head repository: golang/crypto
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.5.0
Choose a head ref
  • 5 commits
  • 9 files changed
  • 3 contributors

Commits on Dec 8, 2022

  1. acme: eliminate arbitrary timeouts in tests

    Fixes golang/go#57107.
    
    Change-Id: I20b1f6ca85170c6b4731d7c7ea06f4db742526cc
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/456123
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Run-TryBot: Bryan Mills <bcmills@google.com>
    Reviewed-by: Roland Shoemaker <roland@golang.org>
    Auto-Submit: Bryan Mills <bcmills@google.com>
    Bryan C. Mills authored and gopherbot committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    f495dc3 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2022

  1. ssh: ensure that handshakeTransport goroutines have finished before C…

    …lose returns
    
    This fixes a data race in the tests for x/crypto/ssh, which expects to
    be able to examine a transport's read and write counters without
    locking after closing it.
    
    (Given the number of goroutines, channels, and mutexes used in this
    package, I wouldn't be surprised if other concurrency bugs remain.
    I would suggest simplifying the concurrency in this package, but I
    don't intend to follow up on that myself at the moment.)
    
    Fixes golang/go#56957.
    
    Change-Id: Ib1f1390b66707c66a3608e48f3f52483cff3c1f5
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/456758
    Reviewed-by: Roland Shoemaker <roland@golang.org>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Auto-Submit: Bryan Mills <bcmills@google.com>
    Run-TryBot: Bryan Mills <bcmills@google.com>
    Bryan C. Mills authored and gopherbot committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    23edec0 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2022

  1. internal/wycheproof: also use Verify in TestECDSA

    Check both Verify and VerifyASN1 in the ECDSA tests.
    
    Change-Id: Id767354484a7da18ae4e00cd6f2a01a2909e6732
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/453755
    Reviewed-by: Than McIntosh <thanm@google.com>
    Run-TryBot: Roland Shoemaker <roland@golang.org>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Reviewed-by: Filippo Valsorda <filippo@golang.org>
    rolandshoemaker committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    7e3ac20 View commit details
    Browse the repository at this point in the history
  2. bcrypt: reject passwords longer than 72 bytes

    By design, bcrypt only uses the first 72 bytes of a password when
    generating a hash. Most implementations, including the reference one,
    simply silently ignore any trailing input when provided passwords longer
    than 72 bytes. This can cause confusion for users who expect the entire
    password to be used to generate the hash.
    
    In GenerateFromPassword, reject passwords longer than 72 bytes.
    CompareHashAndPassword will still accept these passwords, since we
    cannot break hashes that have already been stored.
    
    Fixes golang/go#36546
    
    Change-Id: I039addd2a2961a7fa9d1e4a3e892a9e3c8bf4c9a
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/450415
    Reviewed-by: Damien Neil <dneil@google.com>
    Reviewed-by: Jason McNeil <jmcneil@x2studios.com>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Reviewed-by: Filippo Valsorda <filippo@golang.org>
    Auto-Submit: Roland Shoemaker <roland@golang.org>
    Run-TryBot: Roland Shoemaker <roland@golang.org>
    rolandshoemaker authored and gopherbot committed Dec 21, 2022
    1 Configuration menu
    Copy the full SHA
    bc7d1d1 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2023

  1. go.mod: update golang.org/x dependencies

    Update golang.org/x dependencies to their latest tagged versions.
    Once this CL is submitted, and post-submit testing succeeds on all
    first-class ports across all supported Go versions, this repository
    will be tagged with its next minor version.
    
    Change-Id: I25128883772569c8f729b091b0efcbc4afcbea67
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/460500
    Run-TryBot: Gopher Robot <gobot@golang.org>
    Auto-Submit: Gopher Robot <gobot@golang.org>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    Reviewed-by: Heschi Kreinick <heschi@google.com>
    gopherbot committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    3d872d0 View commit details
    Browse the repository at this point in the history
Loading