Skip to content

do not glob a path if it exists 'unglobbed' #797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sdementen
Copy link

fix #680

@Byron
Copy link
Member

Byron commented Oct 13, 2018

@sdementen Thanks a lot for your contribution! Unfortunately some tests seem to legitimately fail. Do you think that can be fixed?
If that should work out, it would be great to have a specific test as well that would fail the current change is not applied.
Thank you

@codecov-io
Copy link

Codecov Report

Merging #797 into master will increase coverage by 0.06%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #797      +/-   ##
==========================================
+ Coverage   94.71%   94.78%   +0.06%     
==========================================
  Files          59       59              
  Lines        9369     9602     +233     
==========================================
+ Hits         8874     9101     +227     
- Misses        495      501       +6
Impacted Files Coverage Δ
git/index/base.py 94.52% <50%> (-0.11%) ⬇️
git/repo/base.py 95.37% <0%> (-0.83%) ⬇️
git/test/test_docs.py 100% <0%> (ø) ⬆️
git/objects/blob.py 100% <0%> (ø) ⬆️
git/refs/remote.py 100% <0%> (ø) ⬆️
git/test/test_diff.py 100% <0%> (ø) ⬆️
git/test/performance/test_streams.py 100% <0%> (ø) ⬆️
git/test/test_commit.py 100% <0%> (ø) ⬆️
git/test/test_tree.py 100% <0%> (ø) ⬆️
git/test/test_exc.py 100% <0%> (ø) ⬆️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8591a0...ea766c5. Read the comment docs.

@Byron
Copy link
Member

Byron commented Sep 28, 2019

Thanks a lot for your contribution thus far !
I am closing this PR due to prolonged inactivity. Please feel free to reopen it in case it can proceed.

@Byron Byron closed this Sep 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Index.add fail silently when path contains character [
3 participants