Skip to content

Include test files in sdists #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

toddrme2178
Copy link

These files are missing from sdists but are needed for the unit tests as far as I can determine.

These files are missing from sdists but are needed for the unit tests as far as I can determine.
@Byron Byron added this to the v2.1.12 - Bugfixes milestone Aug 20, 2018
@Byron
Copy link
Member

Byron commented Aug 20, 2018

Thanks a lot for your contribution!
Right now I am not on a computer in the traditional sense and can’t verify GitPython source-distributions are still working with the change.
Once that is done, I will happily merge.

@Byron Byron self-assigned this Aug 20, 2018
@Byron
Copy link
Member

Byron commented Oct 13, 2018

I just took a look and noticed that this increases the file size to nearly 6MB on a garbage collected git repository. As most people depending on GitPython (as I presume) just want use it, big download sizes add latency to their workflow on installation. They wouldn't benefit from running the tests at all.

Do you think that there is a way to satisfy your needs of making the tests runnable, while keeping the download size for users who are not interested in this small?

@toddrme2178
Copy link
Author

toddrme2178 commented Oct 15, 2018 via email

@Byron
Copy link
Member

Byron commented Oct 21, 2018

@toddrme2178 Thanks for your reply. I agree, there are options, but they seem to be quite a lot of effort, too, which I believe nobody wants to invest right now.
Therefore and with some regret as some effort is lost, I think it's best to close this PR.

@Byron Byron closed this Oct 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants