Skip to content

Fix bug in diff parser output #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2016
Merged

Conversation

nvie
Copy link
Contributor

@nvie nvie commented May 30, 2016

The diff --patch output parser was missing some edge case where Git would encode non-ASCII chars in path names as octals, but these weren't decoded properly.

\360\237\222\251.txt

Decoded via utf-8, that will return:

💩.txt

The diff --patch parser was missing some edge case where Git would
encode non-ASCII chars in path names as octals, but these weren't
decoded properly.

    \360\237\222\251.txt

Decoded via utf-8, that will return:

    💩.txt
@nvie nvie force-pushed the fix-octal-escaped-path-parser-bug branch from cc1c258 to 1faf84f Compare May 30, 2016 13:44
@nvie
Copy link
Contributor Author

nvie commented May 30, 2016

@Byron This is a bug we've seen in production for some time now. Happy for me to release 2.0.4 with this fix right now?

@Byron Byron added this to the v2.0.4 - Bugfixes milestone May 30, 2016
@Byron Byron merged commit f5089d9 into master May 30, 2016
@Byron
Copy link
Member

Byron commented May 30, 2016

No objections, please feel free to make a release.
Something I usually do as well is to keep the milestones in sync, and thus create a new one with the upcoming release, and move all open issues from the just-released milestones into it. The latter can then be closed officially, which will then become another way for the inclined audience to see which issues/PRs made it in there.
Don't feel obliged, as I can do it when I see a disparity, but recently I noticed that I probably have made some mistakes while doing so after the fact.

In any case, thanks for your contribution :) !

@nvie nvie deleted the fix-octal-escaped-path-parser-bug branch May 30, 2016 17:19
@nvie
Copy link
Contributor Author

nvie commented May 30, 2016

Sure, will do!

@nvie
Copy link
Contributor Author

nvie commented May 30, 2016

2.0.4 is now up on PyPI :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants