-
-
Notifications
You must be signed in to change notification settings - Fork 939
Add support for diffing against root commit #408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
9ae1f21
Pass through the $HOME env var to the tox env
nvie 83156b9
Add Python 3.5 env
nvie 5de21c7
Support "root" as a special value in .diff() calls
nvie aae2a73
Fix comment
nvie 82b533f
Use a special object rather than a string
nvie 07b124c
Update changelog for next release
nvie c042f56
Export NULL_TREE
nvie 1875885
Fix test cases
nvie 6bdaa46
Drop dependency on six
nvie 28afef5
Perform diff-tree recursively to have the same output as diff
nvie 722473e
Remove Python 2.6 hack
nvie 3297fe5
Merge remote-tracking branch 'upstream/master'
nvie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Support "root" as a special value in .diff() calls
This enabled getting diff patches for root commits.
- Loading branch information
commit 5de21c7fa2bdd5cd50c4f62ba848af54589167d0
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
--- /dev/null | ||
+++ b/CHANGES | ||
@@ -0,0 +1,7 @@ | ||
+======= | ||
+CHANGES | ||
+======= | ||
+ | ||
+0.1.0 | ||
+===== | ||
+initial release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When using the string 'root', I am afraid that it would permanently block usage of a similarly named treeish, which could be the name of a tag or ref for example.
How would you circumvent this problem (or is it maybe not a problem at all) ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a very good argument against it indeed. Rather than using a special string here, I've now opted for a special object, a little bit like the Index class. New usage:
Fixed in 82b533f. What do you think of this API?