Fix another bug found by Fedora users, indented config sections. Newer RawConfigParser handles them fine, as does git config. #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings over some new code from RawConfigParser that handles lines
that start with spaces but are also sections themselves, eg:
[color]
ui = auto
[color "branch"]
Previously this would cause a traceback.
(https://bugzilla.redhat.com/show_bug.cgi?id=706218)
|
Gah, don't pull this, it doesn't fix it like I thought it did. |
|
ok, but let me paste my previous reply, which basically asks you to work with the unittests. Could you modify and existing fixture (like. git_config in test/fixtures) to contain lines that your change is fixing, maybe including some variations you make up that you think should be fine as well. Once that is verified, I will be glad to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings over some new code from RawConfigParser that handles lines
that start with spaces but are also sections themselves, eg:
[color]
ui = auto
[color "branch"]
Previously this would cause a traceback.
(https://bugzilla.redhat.com/show_bug.cgi?id=706218)