Skip to content

Handle indented comments in git config files (issue #17) #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Handle indented comments in git config files (issue #17) #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Handle indented comments in git config files 
It's perfectly valid for a git config file to contain comments inside
sections, e.g.:

[core]
	# This is a shared repository
	sharedRepository = true

The git tools all parse this fine while GitPython was choking on it.
  • Loading branch information
@tmzullinger
tmzullinger committed May 23, 2011
commit 69253459a4924e2bf71cf42cd5e2c1c9e33af137
3 changes: 2 additions & 1 deletion git/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,13 +205,14 @@ def _read(self, fp, fpname):
optname = None
lineno = 0
e = None # None, or an exception
comment_re = re.compile('^\s*[#;]')
while True:
line = fp.readline()
if not line:
break
lineno = lineno + 1
# comment or blank line?
if line.strip() == '' or line[0] in '#;':
if line.strip() == '' or comment_re.match(line):
continue
if line.split(None, 1)[0].lower() == 'rem' and line[0] in "rR":
# no leading whitespace
Expand Down