Handle indented comments in git config files (issue #17) #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's perfectly valid for a git config file to contain comments inside sections, e.g.: [core] # This is a shared repository sharedRepository = true The git tools all parse this fine while GitPython was choking on it.
|
Could you modify and existing fixture (like. git_config in test/fixtures) to contain comments, maybe including some variations you make up that you think should be fine as well. Once that works, I will be glad to merge. |
|
I have implemented the contents of this pull request and pushed the changes to the new 0.3 branch. This is to indicate that GitPython 0.3 reached the end of its life and is in maintenance mode. A proper release of 0.3 will follow. Master now moved on to the latest stable development, which will be 0.4 one day. As master was reset, you will have to reset your local master as well. Thanks for your participation, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's perfectly valid for a git config file to contain comments inside
sections, e.g.:
The git tools all parse this fine while GitPython was choking on it.