Skip to content

Option to skip packed_refs in iter_items() #1581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

wonder-mice
Copy link
Contributor

In cases where tool only need recent-ish refs (e.g. base branch autodetect) it will save a lot of time if packed_refs can be excluded from search.

In cases where tool only need recent-ish refs (e.g. base branch
autodetect) it will save a lot of time if `packed_refs` can be excluded
from search.
Copy link
Member

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for contributing!

This looks good to me, and an can be merged once CI is green. Thank you.

@@ -704,6 +706,7 @@ def iter_items(
cls: Type[T_References],
repo: "Repo",
common_path: Union[PathLike, None] = None,
packed_refs: bool = True,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation seems to be missing.

@Byron Byron added this to the v3.1.32 - Bugfixes milestone May 4, 2023
@Byron Byron removed this from the v3.1.32 - Bugfixes milestone Jul 10, 2023
@Byron
Copy link
Member

Byron commented Sep 7, 2023

Is it possible to get this addressed? Otherwise the PR is in danger to being closed for, to my mind, no good reason. Thanks a lot.

@Byron
Copy link
Member

Byron commented Sep 11, 2023

Closing due to inactivity.

@Byron Byron closed this Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants