Skip to content

Fix blob filter types #1459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 2, 2022
Merged

Fix blob filter types #1459

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
da88a6d
Fix blob filter types
AustinScola Jun 21, 2022
a6ce118
Add stage type to all
AustinScola Jun 21, 2022
d171365
Move stage type def
AustinScola Jun 21, 2022
1314d63
Change to not stringify paths
AustinScola Jun 26, 2022
c6a018b
Fix pathlike type annotation typo
AustinScola Jun 26, 2022
cc80e6b
Remove usage of `PosixPath.is_relative_to`
AustinScola Jun 26, 2022
420d2af
Use generator instead of map
AustinScola Jun 26, 2022
ed45d5b
Fix blob filter path shorter than filter path
AustinScola Jun 28, 2022
da59d74
Remove stage type as parameter from blob filter test
AustinScola Jul 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix pathlike type annotation typo
  • Loading branch information
@AustinScola
AustinScola committed Jun 26, 2022
commit c6a018bdf802326f89e8c93ccac79fae78d94974
2 changes: 1 addition & 1 deletion git/index/typ.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ def __init__(self, paths: Sequence[PathLike]) -> None:
self.paths = paths

def __call__(self, stage_blob: Tuple[StageType, Blob]) -> bool:
blob_pathlike: Pathlike = stage_blob[1].path
blob_pathlike: PathLike = stage_blob[1].path
blob_path: Path = blob_pathlike if isinstance(blob_pathlike, Path) else Path(blob_pathlike)
for pathlike in self.paths:
path: Path = pathlike if isinstance(pathlike, Path) else Path(pathlike)
Expand Down