-
-
Notifications
You must be signed in to change notification settings - Fork 934
Re-enable Cygwin CI and get most tests passing #1455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think this got deleted because the tests were failing, so let's see what happens!
People can change the `/cygdrive` prefix for mounting Windows drives; `/` and `/mnt` are both popular. `/proc/cygdrive` is always going to have the drive letters under it.
Got this wrong the first time through
Hopefully this avoids the mismatched directories with saving into a user temporary directory with one user name and reading from a user temporary directory with a different user name.
Echoing the commands in shell scripts in tests causes problems with the tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for putting in all this work and make GitPython
work on cygwin once again.
Regarding the failing tests, I'd be OK with ignoring them if run on cygwin and providing a fix in other PRs. The failures are all related to submodule handling, and I think that functionality isn't necessarily widely used anymore.
Got the wrong one the first time.
I got that done. Do you want to merge as-is, or do you want me to try to clean up the commits a bit?
SciPy uses submodules to vendor boost, and I think both SciPy and NumPy include numpydoc via submodule. I haven't had any problems with the command-line interface (that can't be attributed to user error), but I only really use |
Thanks a lot! This looks good to me and I for one like to see all the steps it took in the history, thus I will merge as is.
And for that, one could also use |
It looks like the Cygwin CI testing was disabled a while back, possibly as part of the move to GHA. I added a separate Cygwin CI run to the GitHub actions and tried to get the tests passing. I have three test failures left that I don't understand, and hope someone here knows what's going on.
I can move the test to a separate step in the existing GHA workflow if that would work better in this project, or move it to a separate PR to wait for the last three tests to pass while the other fixes go in.