Skip to content

test & fix for mangled tagger names #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2011
Merged

test & fix for mangled tagger names #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion git/objects/tag.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ def _set_cache_(self, attr):

self.tag = lines[2][4:] # tag <tag name>

tagger_info = lines[3][7:]# tagger <actor> <date>
tagger_info = lines[3]# tagger <actor> <date>
self.tagger, self.tagged_date, self.tagger_tz_offset = parse_actor_and_date(tagger_info)

# line 4 empty - it could mark the beginning of the next header
Expand Down
10 changes: 10 additions & 0 deletions git/test/test_refs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,16 @@ def test_tag_base(self):
# END for tag in repo-tags
assert tag_object_refs
assert isinstance(self.rorepo.tags['0.1.5'], TagReference)


def test_tags_author(self):
tag = self.rorepo.tags[0]
tagobj = tag.tag
assert isinstance( tagobj.tagger, Actor )
tagger_name = tagobj.tagger.name
assert tagger_name == 'Michael Trier'



def test_tags(self):
# tag refs can point to tag objects or to commits
Expand Down