Warn when working tree is empty on non-bare repos #1375
Conversation
|
Can even be considered to raise an exception here. |
There was a problem hiding this comment.
I think it would be interesting to explore how GitPython reacts if the working tree dir is None even though the repo isn't bare. Because that seems like it's a bug as the working tree dir should be set even if it's empty.
In other words, non-bare repositories that are empty, i.e. a .git/ directory in an otherwise empty directory, should not lead to surprises except for being empty.
Note that the main branch might not be born yet on empty repositories, which is something the caller always has to be aware of independently.
Independently of all that, it would definitely help this PR along if there would be more substance to the encountered issues in the form of 'expected - actual' comparisons.
|
Since this PR has been waiting for changes for a while now I think it's fair to close it for now. |
When loading an empty repo by accident and iterating through commits lead to suprprising results. It should be warned while loading the non-bare repo that this does not appear to be a repo.