Skip to content

Let remote.push return a PushInfoList #1360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 13, 2021
Merged

Let remote.push return a PushInfoList #1360

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
70e4bb8
Let remote.push return a PushInfoList
Sjord Oct 12, 2021
6fc830a
Test that return value of push is a list-like object
Sjord Oct 13, 2021
5c15975
Rename exception to error, raise_on_error to raise_if_error
Sjord Nov 8, 2021
808179e
Test raise_if_error
Sjord Nov 8, 2021
e5fd7b7
Add raise_if_error() to tutorial
Sjord Nov 9, 2021
56a395f
Fix type handing on PushInfoList
Sjord Nov 9, 2021
bc76d4a
Specify type for PushInfoList.error
Sjord Nov 9, 2021
a270deb
Extend IterableList[PushInfo] instead of IterableList
Sjord Nov 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add raise_if_error() to tutorial
  • Loading branch information
@Sjord
Sjord committed Nov 9, 2021
commit e5fd7b71545b42ae9da9943d922341196c405824
3 changes: 2 additions & 1 deletion test/test_docs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,8 @@ def test_references_and_objects(self, rw_dir):
origin.rename('new_origin')
# push and pull behaves similarly to `git push|pull`
origin.pull()
origin.push()
origin.push() # attempt push, ignore errors
origin.push().raise_if_error() # push and raise error if it fails
# assert not empty_repo.delete_remote(origin).exists() # create and delete remotes
# ![25-test_references_and_objects]

Expand Down