Skip to content

Dropping python 3.4 #1131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
drop python 3.4, update .gitignore
  • Loading branch information
Yobmod committed Feb 24, 2021
commit 2f8320b7bf75b6ec375ade605a9812b4b2147de9
3 changes: 0 additions & 3 deletions .appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@ environment:
CYGWIN64_GIT_PATH: "C:\\cygwin64\\bin;%GIT_DAEMON_PATH%"

matrix:
- PYTHON: "C:\\Python34-x64"
PYTHON_VERSION: "3.4"
GIT_PATH: "%GIT_DAEMON_PATH%"
- PYTHON: "C:\\Python35-x64"
PYTHON_VERSION: "3.5"
GIT_PATH: "%GIT_DAEMON_PATH%"
Expand Down
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,5 @@ nbproject
/.vscode/
.idea/
.cache/
.mypy_cache/
.pytest_cache/
1 change: 0 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
# UNUSED, only for reference. If adjustments are needed, please see github actions
language: python
python:
- "3.4"
- "3.5"
- "3.6"
- "3.7"
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ If it is not in your `PATH`, you can help GitPython find it by setting
the `GIT_PYTHON_GIT_EXECUTABLE=<path/to/git>` environment variable.

* Git (1.7.x or newer)
* Python >= 3.4
* Python >= 3.5

The list of dependencies are listed in `./requirements.txt` and `./test-requirements.txt`.
The installer takes care of installing them for you.
Expand Down
2 changes: 1 addition & 1 deletion doc/source/intro.rst
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ The object database implementation is optimized for handling large quantities of
Requirements
============

* `Python`_ >= 3.4
* `Python`_ >= 3.5
* `Git`_ 1.7.0 or newer
It should also work with older versions, but it may be that some operations
involving remotes will not work as expected.
Expand Down
18 changes: 18 additions & 0 deletions errors.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
PermissionError: [WinError 32] The process cannot access the file because it is being used by another process:
'C:\\Users\\yobmod\\AppData\\Local\\Temp\\non_bare_test_root_modulebicpd1jd\\git\\ext\\gitdb' ->
'C:\\Users\\yobmod\\AppData\\Local\\Temp\\non_bare_test_root_modulebicpd1jd\\path\\prefix\\git\\ext\\gitdb'

======================================================================
FAIL: test_conditional_includes_from_git_dir (test.test_config.TestBase)
----------------------------------------------------------------------
Traceback (most recent call last):
File "c:\dev\gitpython\test\lib\helper.py", line 91, in wrapper
return func(self, path)
File "c:\dev\gitpython\test\test_config.py", line 267, in test_conditional_includes_from_git_dir
assert config._has_includes()
AssertionError

----------------------------------------------------------------------
Ran 409 tests in 118.716s

FAILED (failures=1, errors=10, skipped=14)
6 changes: 3 additions & 3 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ def build_py_modules(basedir, excludes=[]):
include_package_data=True,
py_modules=build_py_modules("./git", excludes=["git.ext.*"]),
package_dir={'git': 'git'},
python_requires='>=3.4',
python_requires='>=3.5',
install_requires=requirements,
tests_require=requirements + test_requirements,
zip_safe=False,
Expand All @@ -122,10 +122,10 @@ def build_py_modules(basedir, excludes=[]):
"Operating System :: MacOS :: MacOS X",
"Programming Language :: Python",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.4",
"Programming Language :: Python :: 3.5",
"Programming Language :: Python :: 3.6",
"Programming Language :: Python :: 3.7",
"Programming Language :: Python :: 3.8"
"Programming Language :: Python :: 3.8",

]
)
2 changes: 1 addition & 1 deletion tox.ini
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[tox]
envlist = py34,py35,py36,py37,py38,flake8
envlist = py35,py36,py37,py38,flake8

[testenv]
commands = python -m unittest --buffer {posargs}
Expand Down