Skip to content

submodule.move not documented and doesn't update all refs #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mikelikespie opened this issue Aug 19, 2012 · 5 comments
Closed

submodule.move not documented and doesn't update all refs #69

mikelikespie opened this issue Aug 19, 2012 · 5 comments
Assignees

Comments

@mikelikespie
Copy link

Hi,

I am trying to make submodule moving easy.

submodule.move seems to get me half the way there, but it misses a couple things. In new versions of git the .git is just a textfile that references a path in the base directory. This file isn't updated if you move directory depths because it is relative.

It also doesn't update the submodule name in the .git/config which would be helpful. I'll probably be writing the code to do this, but documentation on submodule.move would help too.

Thanks,
Mike

@mikelikespie
Copy link
Author

Also the worktree value in the .git/modules//config needs to be updated

@Byron
Copy link
Member

Byron commented Aug 19, 2012

Hi Mike,

Thanks for bringing this up !

Indeed submodule.move needs to be updated to newer git versions. Currently it should do a move correctly only for git versions prior to the change in the way submodules are handled.

Actually I have a patch for this in my mail box, kindly donated by http://www.alliedtelesis.co.nz/ , that I will upload here for completeness.

Cheers,
Sebastian

@Byron
Copy link
Member

Byron commented Aug 19, 2012

This patch is not yet verified to be working or to actually fix the issue stated here, but it is related.

https://gist.github.com/3393470

@Byron Byron added this to the v0.3.5 - bugfixes milestone Nov 19, 2014
@Byron Byron self-assigned this Jan 19, 2015
@Byron
Copy link
Member

Byron commented Jan 19, 2015

In the latest revision of master and the upcoming release v0.3.6, this issue will be fixed so that .git files are fully supported. During move, these files will be rewritten with the respective relative path.

The second part of this issue, automatically renaming submodules during move, is something I will implement when doing #238. It will only be automatic if the submodule name equals the previous submodule checkout path.

I will close this issue once the linked issue is closed.

@Byron Byron closed this as completed Jan 19, 2015
@Byron
Copy link
Member

Byron commented Jan 19, 2015

You can watch the archived development stream on youtube:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants