Skip to content

Commit b56764b

Browse files
committed
Fixed submodule related issues once again - is it ever going to end ?
1 parent 8b3b222 commit b56764b

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

git/test/db/base.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -601,12 +601,12 @@ def test_rev_parse(self):
601601
self.failUnlessRaises(NotImplementedError, rev_parse, "@{1 week ago}")
602602

603603
def test_submodules(self):
604-
assert len(self.rorepo.submodules) == 1 # non-recursive
604+
assert len(self.rorepo.submodules) == 2 # non-recursive
605605
# in previous configurations, we had recursive repositories so this would compare to 2
606-
# now there is only one left, as gitdb was merged
607-
assert len(list(self.rorepo.iter_submodules())) == 1
606+
# now there is only one left, as gitdb was merged, but we have smmap instead
607+
assert len(list(self.rorepo.iter_submodules())) == 2
608608

609-
assert isinstance(self.rorepo.submodule("git/ext/async"), Submodule)
609+
assert isinstance(self.rorepo.submodule("async"), Submodule)
610610
self.failUnlessRaises(ValueError, self.rorepo.submodule, "doesn't exist")
611611

612612
@with_rw_repo('HEAD', bare=False)

git/test/objects/test_submodule.py

+3-1
Original file line numberDiff line numberDiff line change
@@ -284,7 +284,9 @@ def _do_base_tests(self, rwrepo):
284284

285285
# make sure sub-submodule is not modified by forcing it to update
286286
# to the revision it is supposed to point to.
287-
csm.update()
287+
for subitem in sm.traverse():
288+
subitem.update()
289+
#END checkout to right commit
288290

289291
# this would work
290292
assert sm.remove(dry_run=True) is sm

0 commit comments

Comments
 (0)