Skip to content

Commit 723d20f

Browse files
committed
Improved empty-repo test
Helps to clarify #55
1 parent b08651e commit 723d20f

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

git/test/test_repo.py

+5-2
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ def test_tree_from_revision(self):
8989
assert self.rorepo.tree(tree) == tree
9090

9191
# try from invalid revision that does not exist
92-
self.failUnlessRaises(BadObject, self.rorepo.tree, 'hello world')
92+
self.failUnlessRaises(BadName, self.rorepo.tree, 'hello world')
9393

9494
def test_commit_from_revision(self):
9595
commit = self.rorepo.commit('0.1.4')
@@ -533,7 +533,7 @@ def test_rev_parse(self):
533533
obj = self._assert_rev_parse(path_section)
534534
assert obj.type == ref.object.type
535535
num_resolved += 1
536-
except BadObject:
536+
except (BadName, BadObject):
537537
print("failed on %s" % path_section)
538538
# is fine, in case we have something like 112, which belongs to remotes/rname/merge-requests/112
539539
pass
@@ -698,6 +698,9 @@ def test_empty_repo(self, rw_dir):
698698
# actually, when trying to create a new branch without a commit, git itself fails
699699
# We should, however, not fail ungracefully
700700
self.failUnlessRaises(BadName, r.create_head, 'foo')
701+
self.failUnlessRaises(BadName, r.create_head, 'master')
702+
# It's expected to not be able to access a tree
703+
self.failUnlessRaises(ValueError, r.tree)
701704

702705
new_file_path = os.path.join(rw_dir, "new_file.ext")
703706
touch(new_file_path)

0 commit comments

Comments
 (0)