Skip to content

Commit 19acd4c

Browse files
committed
Add FIXME for what to do next
1 parent 983fda7 commit 19acd4c

File tree

1 file changed

+11
-0
lines changed

1 file changed

+11
-0
lines changed

test/deprecation/test_attributes.py

+11
Original file line numberDiff line numberDiff line change
@@ -103,3 +103,14 @@ def test_private_module_alias_import_warns(self, name: str, fullname: str) -> No
103103
exec(f"from git import {name}")
104104

105105
assert ctx[0].message.args[0].endswith(f"Use {fullname} instead.")
106+
107+
108+
reveal_type(git.util.git_working_dir)
109+
110+
# FIXME: Add one or more test cases that access something like git.util.git_working_dir
111+
# to verify that it is available, and also use assert_type on it to ensure mypy knows
112+
# that accesses to expressions of the form git.util.XYZ resolve to git.index.util.XYZ.
113+
#
114+
# It may be necessary for GitPython, in git/__init__.py, to import util from git.index
115+
# explicitly before (still) deleting the util global, in order for mypy to know what is
116+
# going on. Also check pyright.

0 commit comments

Comments
 (0)