Initial test patch that addresses the issue of the language server being

incompatible with arduino-cli version 1.0.0
Also added some experimental code gives clangd the correct system headers fixing
the diganostic include and missing decleration errors that are seen on the official version.

Author: garzoc

ls/ls.go

@@ -163,9 +163,12 @@ func NewINOLanguageServer(stdin io.Reader, stdout io.Writer, config *Config) *IN
 	logger.Logf("Initial board configuration: %s", ls.config.Fqbn)
 	logger.Logf("%s", globals.VersionInfo.String())
 	logger.Logf("Language server temp directory: %s", ls.tempDir)
+	logger.Logf("### Language server temp directory: %s", ls.tempDir.String())
 	logger.Logf("Language server build path: %s", ls.buildPath)
 	logger.Logf("Language server build sketch root: %s", ls.buildSketchRoot)
 	logger.Logf("Language server FULL build path: %s", ls.fullBuildPath)
+    //os.Link("compile_flags.txt", ls.buildPath.Join("compile_flags.txt").String())
+	//logger.Logf("### Writing to: %s", ls.buildPath.Join("compile_flags.txt").String())
 
 	ls.IDE = NewIDELSPServer(logger, stdin, stdout, ls)
 	ls.progressHandler = newProgressProxy(ls.IDE.conn)
@@ -203,6 +206,8 @@ func (ls *INOLanguageServer) initializeReqFromIDE(ctx context.Context, logger js
 			return
 		}
 
+        //logger.Logf("###Environment donw",)
+
 		if inoCppContent, err := ls.buildSketchCpp.ReadFile(); err == nil {
 			ls.sketchMapper = sourcemapper.CreateInoMapper(inoCppContent)
 			ls.sketchMapper.CppText.Version = 1
@@ -211,12 +216,15 @@ func (ls *INOLanguageServer) initializeReqFromIDE(ctx context.Context, logger js
 			return
 		}
 
+        //logger.Logf("### Readfile ",)
+
 		// Retrieve data folder
 		dataFolder, err := ls.extractDataFolderFromArduinoCLI(logger)
 		if err != nil {
-			logger.Logf("error retrieving data folder from arduino-cli: %s", err)
+			//logger.Logf("### error retrieving data folder from arduino-cli: ")
 			return
 		}
+        //logger.Logf("###Extracted data folder from arduino ",)
 
 		// Start clangd
 		ls.Clangd = newClangdLSPClient(logger, dataFolder, ls)
@@ -226,6 +234,7 @@ func (ls *INOLanguageServer) initializeReqFromIDE(ctx context.Context, logger js
 			logger.Logf("Lost connection with clangd!")
 			ls.Close()
 		}()
+        //logger.Logf("###Client created ",)
 
 		// Send initialization command to clangd (1 sec. timeout)
 		ctx, cancel := context.WithTimeout(context.Background(), time.Second)
@@ -1462,7 +1471,7 @@ func (ls *INOLanguageServer) extractDataFolderFromArduinoCLI(logger jsonrpc.Func
 		}
 		cmdOutput := &bytes.Buffer{}
 		cmd.RedirectStdoutTo(cmdOutput)
-		logger.Logf("running: %s", strings.Join(args, " "))
+		//logger.Logf("### running: %s", strings.Join(args, " "))
 		if err := cmd.Run(); err != nil {
 			return nil, errors.Errorf("running %s: %s", strings.Join(args, " "), err)
 		}
@@ -1473,15 +1482,18 @@ func (ls *INOLanguageServer) extractDataFolderFromArduinoCLI(logger jsonrpc.Func
 			} `json:"directories"`
 		}
 		var res cmdRes
+        //logger.Logf("### parsing -> %s", cmdOutput.String())
 		if err := json.Unmarshal(cmdOutput.Bytes(), &res); err != nil {
+            //logger.Logf("### parser errors -> %s", dataDir)
 			return nil, errors.Errorf("parsing arduino-cli output: %s", err)
 		}
 		// Return only the build path
 		logger.Logf("Arduino Data Dir -> %s", res.Directories.Data)
 		dataDir = res.Directories.Data
 	}
 
-	dataDirPath := paths.New(dataDir)
+	dataDirPath := paths.New("/tmp/wow")
+    //logger.Logf("### return home -> %s", dataDir)
 	return dataDirPath.Canonical(), nil
 }
 

ls/lsp_client_clangd.go

@@ -42,7 +42,19 @@ func newClangdLSPClient(logger jsonrpc.FunctionLogger, dataFolder *paths.Path, l
 	clangdConf := fmt.Sprintln("Diagnostics:")
 	clangdConf += fmt.Sprintln("  Suppress: [anon_bitfield_qualifiers]")
 	clangdConf += fmt.Sprintln("CompileFlags:")
-	clangdConf += fmt.Sprintln("  Add: -ferror-limit=0")
+	//clangdConf += fmt.Sprintln("  Add: -ferror-limit=0")
+	clangdConf += fmt.Sprintln("  Add: [")
+	clangdConf += fmt.Sprintln("    -ferror-limit=0,")
+	//clangdConf += fmt.Sprintln("    -DARDUINO=186,")
+	//clangdConf += fmt.Sprintln("    -DUSBCON=1,")
+	clangdConf += fmt.Sprintln("    -nostdlib,")
+	clangdConf += fmt.Sprintln("    -nostdinc,")
+	clangdConf += fmt.Sprintln("    -isystem=/home/pi/test/build/sketch/tmp/wow/packages/arduino/tools/avr-gcc/7.3.0-atmel3.6.1-arduino7/avr/include/,")
+	clangdConf += fmt.Sprintln("    -I/home/pi/test/tmp/wow/packages/arduino/tools/avr-gcc/7.3.0-atmel3.6.1-arduino7/avr/include/,")
+	clangdConf += fmt.Sprintln("    -F/home/pi/test/tmp/wow/packages/arduino/tools/avr-gcc/7.3.0-atmel3.6.1-arduino7/avr/include/,")
+	clangdConf += fmt.Sprintln("    -I/home/pi/test/tmp/wow/packages/arduino/tools/avr-gcc/7.3.0-atmel3.6.1-arduino7/lib/gcc/avr/7.3.0/include/,")
+	clangdConf += fmt.Sprintln("    -F/home/pi/test/tmp/wow/packages/arduino/tools/avr-gcc/7.3.0-atmel3.6.1-arduino7/lib/gcc/avr/7.3.0/include/")
+	clangdConf += fmt.Sprintln("  ]")
 	if err := clangdConfFile.WriteFile([]byte(clangdConf)); err != nil {
 		logger.Logf("Error writing clangd configuration: %s", err)
 	}
@@ -52,6 +64,8 @@ func newClangdLSPClient(logger jsonrpc.FunctionLogger, dataFolder *paths.Path, l
 		ls.config.ClangdPath.String(),
 		"-log=verbose",
 		"--pch-storage=memory",
+		//"--enable-config",
+		//"--suggest-missing-includes",
 		fmt.Sprintf(`--compile-commands-dir=%s`, ls.buildPath),
 	}
 	if jobs := ls.config.Jobs; jobs == -1 {
@@ -65,6 +79,7 @@ func newClangdLSPClient(logger jsonrpc.FunctionLogger, dataFolder *paths.Path, l
 	if dataFolder != nil {
 		args = append(args, fmt.Sprintf("-query-driver=%s", dataFolder.Join("packages", "**").Canonical()))
 	}
+    args = append(args, fmt.Sprintf("--function-arg-placeholders=0"))
 
 	logger.Logf("    Starting clangd: %s", strings.Join(args, " "))
 	var clangdStdin io.WriteCloser