-
Notifications
You must be signed in to change notification settings - Fork 48.3k
Use console.timeStamp instead of performance.measure in Component Performance Track #32736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sebmarkbage
wants to merge
4
commits into
facebook:main
Choose a base branch
from
sebmarkbage:consoletimestamp
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+438
−296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e6a16c8
to
1640275
Compare
eps1lon
approved these changes
Mar 26, 2025
rickhanlonii
approved these changes
Apr 2, 2025
1640275
to
da665e1
Compare
da665e1
to
887e0e0
Compare
887e0e0
to
50781c2
Compare
Except for errors in DEV where we use the properties extension.
If we use the same start/end time we get the same effect.
50781c2
to
3bc3e8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new extension that Chrome added to the existing
console.timeStamp
similar to the extensions added toperformance.measure
. This one should be significantly faster because it doesn't have the extra object indirection, it doesn't return aPerformanceMeasure
entry and doesn't register itself with the global system of entries.I also use
performance.measure
in DEV for errors since we can attach the error to theproperties
extension which doesn't exist forconsole.timeStamp
.A downside of using this API is that there's no programmatic API for the site itself to collect its own logs from React. Which the previous allowed us to use the standard
performance.getEntries()
for. The recommendation instead will be for the site to patchconsole.timeStamp
if it wants to collect measurements from React just like you're recommended to patchconsole.error
orfetch
or whatever to collect other instrumentation metrics.This extension works in Chrome canary but it doesn't yet work fully in Chrome stable. We might want to wait until it has propagated to Chrome to stable. It should be in Chrome 136.