-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Change sntp default update interval to 6 hours. #5824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This will result in less traffic to the (free and community run) sntp servers.
Change the sntp update interval to 6 hours.
Did you check what is time drift with internal RTC on esp32? |
This change can not be applied here, it would need to be applied upstream (https://github.com/espressif/esp-lwip and/or https://github.com/espressif/esp-idf) OR change Changing to six hours though is a bit excessive as typically one hour is what most systems use today. |
@atanisoft Thanks for the links. @chegewara I already had some challenges with sntp and I measured a drift of about 10s per day. |
On esp32 RTC drift is about 5%, which is 180s per hour. |
Perhaps change to three hours? You can submit a PR to https://github.com/espressif/esp32-arduino-lib-builder and update all sdkconfig. files and once @me-no-dev approves it will be available in arduino-esp32 via PR after about six hours. |
@atanisoft I am a bit confused by the different repos. |
|
Closing this PR and continuing on https://github.com/espressif/esp32-arduino-lib-builder |
Summary
Change sntp default update interval from 1 to 6 hours.
Impact
This PR aims at reducing the amount of requests sent to the (free as-in-beer and community run) ntp time servers.
The amount of requests for the ntp project should be a a lot less (per esp32) than with the current settings.
Rationale
Just from my home network with 5 esp32 controllers there are more than 100 ntp requests per day with the 1 hour update interval.
The ntp project is a community run service and open source projects should strive to minimize their impact on this service.