Skip to content

add DFRobot FireBeetle-ESP32 support #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 5, 2017
Merged

add DFRobot FireBeetle-ESP32 support #239

merged 3 commits into from
Mar 5, 2017

Conversation

ouki-wang
Copy link
Contributor

Please add DFRobot FireBeetle-ESP32 support, thanks

@arcao
Copy link
Contributor

arcao commented Feb 27, 2017 •
edited
Loading

Please change board id from esp32 to firebeetle32. Adding board constants in variants/<board_id>/pins_arduino.h header file will be good too (don't forget to change board_id.build.variant accordingly).

@me-no-dev
Copy link
Member

@ouki-wang will you do the changes that @arcao mentioned? I can not accept this PR as-is

@ouki-wang
Copy link
Contributor Author

@me-no-dev i have add variants for esp32 and modify build.variant . Thanks for arcao's help

@arcao
Copy link
Contributor

arcao commented Mar 2, 2017

@ouki-wang Please change the board_id from esp32 it firebeetle32.

I mean your boards.txt changes should be:

firebeetle32.name=FireBeetle-ESP32

firebeetle32.upload.tool=esptool
firebeetle32.upload.maximum_size=1044464
firebeetle32.upload.maximum_data_size=294912
firebeetle32.upload.wait_for_upload_port=true

...etc...

me-no-dev
me-no-dev approved these changes Mar 5, 2017
View reviewed changes
Copy link
Member

@me-no-dev me-no-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great

boards.txt Outdated

##############################################################

esp32.name=FireBeetle-ESP32
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the board name MUST NOT start with esp32. there already is a board definition that uses it. Use firebeetle32. instead.

@me-no-dev me-no-dev merged commit 8289f34 into espressif:master Mar 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@me-no-dev me-no-dev me-no-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ouki-wang @arcao @me-no-dev