Skip to content

Udp endPacket() returns -1 on error and 7 on success #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tonu42 opened this issue Jan 18, 2017 · 3 comments
Closed

Udp endPacket() returns -1 on error and 7 on success #138

tonu42 opened this issue Jan 18, 2017 · 3 comments

Comments

@tonu42
Copy link

tonu42 commented Jan 18, 2017

Been using Udp a lot and believe when the packet fails to send successfully it should return 0, and on success a 1.

From cores/esp32/Udp.h

// Returns 1 if the packet was sent successfully, 0 if there was an error virtual int endPacket() =0;

Below screen shots to support.

image

image

me-no-dev added a commit that referenced this issue Jan 19, 2017
Change return value of UDP::endPacket() to match specifications

Ref: #138
@me-no-dev
Copy link
Member

thanks for noting :) fixed in the latest commit.

@tonu42
Copy link
Author

tonu42 commented Jan 19, 2017

Glad to have helped. Glad I was not mistaken. This was my first ever issue I reported on Github! Trying to be involved with the ESP32 development to make it better for everyone. Hope you did not think I was nitpicking.

@me-no-dev
Copy link
Member

no worries :) things like that are important and easy to miss at the same time

blue-2357 pushed a commit to blue-2357/arduino-esp32 that referenced this issue Jul 17, 2024
Change return value of UDP::endPacket() to match specifications

Ref: espressif/arduino-esp32#138
dash0820 added a commit to dash0820/arduino-esp32-stripped that referenced this issue Mar 10, 2025
Change return value of UDP::endPacket() to match specifications

Ref: espressif/arduino-esp32#138
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants