Skip to content

Windows fails get.py to download toolchain #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hoopsurfer opened this issue Jan 16, 2017 · 6 comments
Closed

Windows fails get.py to download toolchain #134

hoopsurfer opened this issue Jan 16, 2017 · 6 comments

Comments

@hoopsurfer
Copy link

Needed to comment out "import requests" in get.py to allow it to run on Windows 10. Seems this import was added recently. Note current get.py generates the following error:

Traceback (most recent call last):
File "get.py", line 18, in
import requests
ImportError: No module named requests

@hicotton02
Copy link

I had the same issue, just install the requests module "pip install requests" from the git bash.

@hoopsurfer
Copy link
Author

Appears "requests" was not needed on Windows, not sure about other platforms. Either remove the import or update the Windows install instructions with:

$ python -m pip install --upgrade pip && \

pip install pyserial &&
pip install requests

@me-no-dev
Copy link
Member

ant to me it seems that Windows is a hit and miss situation. I am not a Windows user but did spend on a license and all and run clean installs on 32 and 64 bit windows 10 machines with 0 issues, but then many people complain about certificate not validated for download or some other mishap while installing...
what is the correct recipe to make it work for all?

@hoopsurfer
Copy link
Author

Is "import requests" doing anything in get.py? If not then remove that line from get.py and it will fix this, otherwise tweak the Windows instructions to say: "pip install pyserial requests" and this issue is closed.

@tobozo
Copy link
Contributor

tobozo commented Jan 18, 2017

run pip install requests, it's there to handle installations where Cygwin libs are missing

also see #108

me-no-dev pushed a commit that referenced this issue Jan 18, 2017
* Followup to PR #126

Forgot to mention the extra `pip install requests` in the ReadMe and saw issue #134

* Update windows.md
@me-no-dev
Copy link
Member

And it's all to binary for Windows now, so no more Python or pip required :)
Closing this issue!

brentru pushed a commit to adafruit/arduino-esp32 that referenced this issue Oct 22, 2024
reordered the actions, so clang-format and doxygen are run first
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants