Skip to content

formalization of LEA's mdns rewrite #5450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Dec 8, 2018
Merged

formalization of LEA's mdns rewrite #5450

merged 9 commits into from
Dec 8, 2018

Conversation

devyte
Copy link
Collaborator

@devyte devyte commented Dec 7, 2018

Step 1: code.

  • Removed typedef structs, which aren't needed in C++
  • Minor changes to polledTimeout for compatibility with the required usage
  • Wrapper MDNSTimeFlag to implement the functionality in terms of polledTimeout
  • Some namespace gymnastics
  • Other minor details

LaborEtArs
LaborEtArs approved these changes Dec 8, 2018
View reviewed changes
Copy link
Contributor

@LaborEtArs LaborEtArs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be fine to me :-)

@devyte devyte self-assigned this Dec 8, 2018
@devyte devyte added this to the 2.5.0 milestone Dec 8, 2018
@devyte devyte merged commit 4d15590 into esp8266:master Dec 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaborEtArs LaborEtArs LaborEtArs approved these changes

Assignees

@devyte devyte

Labels
type: code cleanup
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@devyte @LaborEtArs