Fix init array order #2074
Fix init array order #2074
Conversation
LX106 compiler generates the constructor list in reverse order, as you can read at: https://github.com/jcmvbkbc/gcc-xtensa/blob/de95b6b65d806a648434e73a6db85f1e74d62ec8/gcc/varasm.c#L1391
unaiur
force-pushed
the
fix_init_array_order
branch
from
2322660 to
d6fecbc
Compare
Current coverage is 26.31%@@ master #2074 diff @@
==========================================
Files 19 19
Lines 3634 3634
Methods 328 328
Messages 0 0
Branches 585 585
==========================================
Hits 956 956
Misses 2513 2513
Partials 165 165
|
|
What exactly do you mean by "inverse order"? Afaik the standard doesn't define the order of initialization for global objects. What do you use as reference for "correct order"? |
|
The correct order is the order described in the init_priority attribute of https://gcc.gnu.org/onlinedocs/gcc/C_002b_002b-Attributes.html Best regards
|
|
I've written an small testcase here http://pastebin.com/HpcXqXsm that shows the issue. |
|
Ah, right, priorities are not handled correctly this way. Thanks for the fix. |
GCC for Xtensa LX106 generates constructor sections names in inverse order.
The link script in tools/sdk/ld/eagle.app.v6.common.ld is also designed to create an __init_array in inverse order.
So we must traverse that array starting from the end.