-
Notifications
You must be signed in to change notification settings - Fork 1k
Issue 12830 multi target demo console #13307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Epica3055
wants to merge
21
commits into
dotnet:main
from
Epica3055:Issue_12830_Multi-Target_DemoConsole
Closed
Issue 12830 multi target demo console #13307
Epica3055
wants to merge
21
commits into
dotnet:main
from
Epica3055:Issue_12830_Multi-Target_DemoConsole
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t multiple target frameworks (`$(NetCurrent)-windows;net481`). Fixes dotnet#12830 - Updated `DemoConsole.csproj` and `DesignSurfaceExt.csproj` to support multiple target frameworks (`$(NetCurrent)-windows;net481`). - Adjusted `TargetFramework` property to avoid over-building. - Enabled `SignAssembly` and `GenerateAssemblyInfo` properties in the project files. - Updated resource and reference handling in `DemoConsole.csproj` and `DesignSurfaceExt.csproj` to improve compatibility. - Fixed `Controls.AddRange` usage to use the correct syntax in `MainForm.MyUserControl.cs`. - Corrected `Controls.AddRange` call in `MainForm.cs` to `Controls.Add`. - Suppressed `IDE0057` warning and reverted to `Substring` method for compatibility in `NameCreationServiceImp.cs`. - Changed `StartsWith('_')` check by directly accessing the first character in `NameCreationServiceImp.cs` for compatibility. - Disabled error `CA1824` for projects `DemoConsole` and `DesignSurficeExt`, because it would be triggered even though properly configured in those projects, according to the fix provided by the [documentation](https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1824#fix-violations). - None - No - Minimal - `DemoConsole` would not run on `net481`. - Manual - 10.0.100-preview.3.25125.5
…'s lauchSettings.json's nativeDebugging to false
17089fa
to
5c30d37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is draft PR testing something
Microsoft Reviewers: Open in CodeFlow