[Testing] Fix for flaky tests which randomly fails on CI - 9 #28887
+9
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @@anandhan-rajagopal! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
dotnet-policy-service
bot
added
the
partner/syncfusion
| //give the cv time to scroll | ||
| var rand = new Random(); | ||
| await Task.Delay(rand.Next(10, 200)); | ||
| await Task.Delay(200); |
There was a problem hiding this comment.
Using a fixed delay may not consistently guarantee that the scroll operation has completed on all devices. Consider waiting for a specific UI element state or condition that explicitly signals that scrolling is done.
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
rmarinho
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve the stability and reliability of the tests in the
src/Controls/testsdirectory. The most important changes involve adjusting delays and timeouts to ensure proper synchronization and adding additional checks to confirm the completion of UI operations.Improvements to test synchronization:
src/Controls/tests/TestCases.HostApp/Issues/Issue10222.cs: Adjusted the random delay inInitCV()to a fixed 200 milliseconds to ensure consistent scrolling behavior.src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue10222.cs: Added specific timeout values toApp.WaitForElementcalls inIssue10222Test()to handle potential timing issues more robustly.Enhancements to UI operation checks:
src/Controls/tests/TestCases.Shared.Tests/Tests/DragAndDropUITests.cs: Added multipleApp.WaitForElementcalls inDropEventCoordinates()to confirm the completion of the drag and drop operation by waiting for all relevant UI elements.