Skip to content

[Documentation] Page.DisplayAlert wrong documentation (Task vs Task<bool>) - fix #28521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2025

Conversation

kubaflo
Copy link
Contributor

@kubaflo kubaflo commented Mar 19, 2025

Description of Change

I've overwritten the docs for methods that return Task instead of Task

Default

Screenshot 2025-03-19 at 19 59 34

New one for the 2 methods that return Task

Screenshot 2025-03-19 at 19 59 21
Screenshot 2025-03-19 at 19 59 05

Issues Fixed

Fixes #28517

@kubaflo kubaflo requested a review from a team as a code owner March 19, 2025 19:04
@kubaflo kubaflo requested review from jfversluis and PureWeen March 19, 2025 19:04
@kubaflo kubaflo self-assigned this Mar 19, 2025
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Mar 19, 2025
Copy link
Contributor

Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@mattleibow mattleibow added the area-docs Conceptual docs, API docs, Samples label Mar 19, 2025
@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@rmarinho rmarinho moved this from Todo to Ready To Review in MAUI SDK Ongoing Mar 20, 2025
@rmarinho rmarinho added this to the .NET 9 SR6 milestone Mar 20, 2025
@github-project-automation github-project-automation bot moved this from Ready To Review to Approved in MAUI SDK Ongoing Mar 20, 2025
@rmarinho rmarinho merged commit 009b4f1 into dotnet:main Mar 20, 2025
110 of 128 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in MAUI SDK Ongoing Mar 20, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Apr 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-docs Conceptual docs, API docs, Samples community ✨ Community Contribution
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Documentation issue] Page.DisplayAlert wrong documentation (Task vs Task<bool>)
5 participants