[Mac Catalyst] NullReferenceException in DragAndDropDelegate - FIX
#28417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartyIX
commented
Mar 14, 2025
| @@ -122,7 +122,7 @@ session.LocalDragSession.Items[0].LocalObject is CustomLocalStateData cdi && | |||
| _viewHandler.VirtualView is View view) | |||
| { | |||
| HandleDrop(view, cdi.DataPackage, session, new PlatformDropEventArgs(cdi.View.Handler.PlatformView as UIView, interaction, session)); | |||
| HandleDropCompleted(cdi.View, new PlatformDropCompletedEventArgs(cdi.View.Handler.PlatformView as UIView, interaction, session)); | |||
| HandleDropCompleted(cdi.View, new PlatformDropCompletedEventArgs(cdi.View.Handler?.PlatformView as UIView, interaction, session)); | |||
rmarinho
requested changes
Mar 14, 2025
MartyIX
force-pushed
the
feature/2025-03-14-mac-avoid-NRE-in-HandleDropCompleted
branch
from
7194a89 to
e1238e1
Compare
MartyIX
force-pushed
the
feature/2025-03-14-mac-avoid-NRE-in-HandleDropCompleted
branch
4 times, most recently
from
c53eac9 to
db379de
Compare
MartyIX
commented
Mar 15, 2025
MartyIX
force-pushed
the
feature/2025-03-14-mac-avoid-NRE-in-HandleDropCompleted
branch
from
db379de to
4c71922
Compare
MartyIX
commented
Mar 15, 2025
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
StephaneDelcroix
previously approved these changes
Mar 17, 2025
rmarinho
previously approved these changes
Mar 17, 2025
MartyIX
commented
Mar 17, 2025
MartyIX
force-pushed
the
feature/2025-03-14-mac-avoid-NRE-in-HandleDropCompleted
branch
from
4c71922 to
7216a9b
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
rmarinho
approved these changes
Mar 17, 2025
MartyIX
deleted the
feature/2025-03-14-mac-avoid-NRE-in-HandleDropCompleted
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
I'm not exactly sure if the fix is correct but I have verified that it fixes the crash for my application.
Test
Drag the blue square on the silver element below and the blue square is "removed" in the drop event handler. Consequently, drag-completed handler cannot be called with the proper platform view.
(This is how it looks like on Windows but the bug manifests on macOS.)
Issues Fixed
Fixes #28416