Remove PlatformWrapperView.java setHasShadow #28245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfversluis
added
t/breaking 💥
platform/android 🤖
area-drawing
There was a problem hiding this comment.
PR Overview
This PR resolves a TODO by removing the deprecated setHasShadow method from PlatformWrapperView.java.
- Removed the deprecated setHasShadow method.
- The removal cleans up the API as part of deprecation in preparation for .NET10.
Reviewed Changes
| File | Description |
|---|---|
| src/Core/AndroidNative/maui/src/main/java/com/microsoft/maui/PlatformWrapperView.java | Removed deprecated setHasShadow method |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
|
/azp run |
|
🚨 API change(s) detected @davidbritch FYI |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
requested changes
Mar 10, 2025
There was a problem hiding this comment.
Requires changes in the PublicAPI:
C:\a\_work\1\s\src\Core\src\PublicAPI\net-android\PublicAPI.Shipped.txt(1862,1): error RS0017: Symbol 'Microsoft.Maui.PlatformWrapperView.SetHasShadow(bool hasShadow) -> void' is part of the declared API, but is either not public or could not be found (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [C:\a\_work\1\s\src\Core\src\Core.csproj::TargetFramework=net10.0-android35.0]
1 Error(s)
github-project-automation
bot
moved this from Ready To Review
to Changes Requested
in MAUI SDK Ongoing
rmarinho
requested changes
Mar 10, 2025
github-project-automation
bot
moved this from Ready To Review
to Changes Requested
in MAUI SDK Ongoing
|
/rebase |
github-actions
bot
force-pushed
the
remove-java-setHasShadow
branch
from
4b8669b to
12d9dcc
Compare
jsuarezruiz
approved these changes
Mar 21, 2025
|
The failed UITests are unrelated with the changes. |
rmarinho
approved these changes
Mar 21, 2025
github-project-automation
bot
moved this from Ready To Review
to Approved
in MAUI SDK Ongoing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Resolves a todo in code by removing the
setHasShadowmethod fromPlatformWrapperView.java, which was already marked as deprecated.