[Testing] Moved ImageDoesNotLeak test case from Device Test to UI Test #28223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @HarishKumarSF4517! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
dotnet-policy-service
bot
added
the
partner/syncfusion
There was a problem hiding this comment.
PR Overview
This PR moves the Image memory leak test from the device tests to the UI tests to address intermittent failures. Key changes include:
- Removal of the Image memory leak test from the device tests.
- Addition of an Image test case in the MemoryTests switch statement in the HostApp.
- Inclusion of a new ImageDoesNotLeak test method in the Shared tests, and removal of unnecessary internet connectivity checks.
Reviewed Changes
| File | Description |
|---|---|
| src/Controls/tests/TestCases.HostApp/Issues/MemoryTests.cs | Removed the isInternetRequired parameter and added the Image case to the RunMemoryTest switch. |
| src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/MemoryTests.cs | Removed VerifyInternetConnectivity calls and added the ImageDoesNotLeak test method. |
| src/Controls/tests/DeviceTests/Elements/Image/ImageTests.cs | Removed the legacy DoesNotLeak test for Image. |
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
src/Controls/tests/TestCases.HostApp/Issues/MemoryTests.cs:75
- Consider adding a comment in the default branch to indicate that no memory test is defined for unhandled data types, clarifying the intended control flow.
default:
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
approved these changes
Mar 10, 2025
rmarinho
approved these changes
Mar 13, 2025
rmarinho
added a commit
that referenced
this pull request
Mar 17, 2025
* [Testing] Moved ImageDoesNotLeak test case from Device Test to UI Test (#28223) * Enable ImageLeakTest from Device to UI Test * Update MemoryTests.cs * Update MemoryTests.cs * Update GarbageCollectionHelper.cs * [ci] Update arcade and xharness * Update bug-report.yml (#28394) * Update bug-report.yml * Update bug-report.yml * [ci] Cleanup the provisionator Xcode script (#28395) * Upgrade from 1.6.5 to 1.6.6 (#28338) * [testing] Disable CheckEntitlementsForMauiBlazorOnMacCatalyst (#28407) * Made sudo optional for linux jdk provisioning (#28195) When used in some scenarios (eg: Dockerfile), sudo isn't desirable, so this provides a way to optionally remove it from the invocation. --------- Co-authored-by: HarishKumarSF4517 <harish.kumar@syncfusion.com> Co-authored-by: MartyIX <203266+MartyIX@users.noreply.github.com> Co-authored-by: Jonathan Dick <jodick@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to relocate the memory leak tests for the Image control from device tests to UI tests, as they have been failing intermittently in the device tests. Additionally, unnecessary internet checks have been removed from these test cases, since the web view only loads simple HTML code that does not require an internet connection.
Memory Leak Tests Update:
src/Controls/tests/DeviceTests/Elements/Image/ImageTests.cs: Removed theDoesNotLeaktest forImage.src/Controls/tests/TestCases.HostApp/Issues/MemoryTests.cs: Added a newImagecase in theRunMemoryTestmethod to test for memory leaks.src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/MemoryTests.cs: Added a new test methodImageDoesNotLeakto verify thatImagecontrols do not leak memory.Test Case Modifications:
src/Controls/tests/TestCases.HostApp/Issues/MemoryTests.cs: Removed theisInternetRequired: trueparameter from theMemoryTestsattribute.src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/MemoryTests.cs: Removed theVerifyInternetConnectivitycalls from theDatePickerDoesNotLeakandWebViewDoesNotLeaktest methods. [1] [2]