Improve the performance of provisioning and running of device tests #28065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Appium and Android SDK to start
NPM may not return an ok exit code if there's no appium installed. Similarly, we may get no driver list versions and a failed exit code when we query for appium drivers if none are installed.
mattleibow
dismissed
rmarinho’s stale review
It never happened before because this step ran only on some jobs. I now made it always redirect the logs and it appears that on devdiv the reg vale was not set, but azure it is. I just made this step override the values. Now we should get windows logs for all runs.
rmarinho
approved these changes
Mar 5, 2025
bhavanesh2001
pushed a commit
to bhavanesh2001/maui
that referenced
this pull request
Mar 7, 2025
…otnet#28065) * Use MSBuild for provisioning Appium and Android SDK to start * We use Nexus 5X as the device type currently * Fix provision call / logs path * Ignore exit codes NPM may not return an ok exit code if there's no appium installed. Similarly, we may get no driver list versions and a failed exit code when we query for appium drivers if none are installed. * Fix call to target * Provision JDK as well * Provision from pipeline * yaml fixes * Yaml fix * Add project to build invocation * Restore dotnet tools first * Restore tools after clear cache * Ensure winget is installed first * Download jdk msi and install it * Different download location * Property name for downloaded file * Separate provisioning steps * Log more jdk list info * Update provision.yml * Fix batching * Log msiexec install * Split up android provisioning steps * Fix indentation * Update tool with bugfix * JDK: Try default installdir on windows * Android: Option to install only default api levels * Update provision.yml * Fix parameter passing * MSBuild log diag * Skip setting JAVA_HOME * Compatible gradle versions for JDK 17 * Set JDK_HOME again * Try to pick up jdk for gradle * Fix type/var name * Always look up android home * Simplify locate of best JDK * Cake runs with stdout * Disable the cleaner as per comment * Less verbose logging * Update and comment out Tools entry point for now * Remove dup merge step * Add condition for skipping appium doctor * Skip the unsupported task * Only install the image and avd wea are using * windows or mac/linux * apples don't like linus * this too * including * better linux things * no kvm on azure * Revert "no kvm on azure" This reverts commit cdd69a3. * AndroidSdkDirectory * log the info * info * and latest * saf * Provision the JDK on linux too * sudo * list packages * remove latest * this * this * disable kvm for now * Use new emu * better things * provisioning creates the emulators * KVM * order * try this * machines * better logs * oops * cleanups * test boot * oops * test passed * try splitting * this * inside * oops * oooops * 2 * no need for menus in the build * -v:detailed * this * yaml amirite * faster! * moar! * ${{ parameters.appArtifactName }} * this * try this * that * more * ${{ parameters.platform }} * obj * oops * cake * attempt 10 million * skipDotNet * sighs * whaa * ne * oops * safdd * suspision * maybe this one? * to pwsh or not to pwsh * give up for now * test-only * log things * that * this * where is it??? * this * windows has 2 separate builds * maybe this * merge the files and jobs * this * oops * always publish * better * we can skip .net if we don't need it * names * this * try this * try again * ) * yaml is not yaml-ing * debugging yaml * eq * seems to always fail the first time * split to speed up retries * this * better * try harder * better booting and reties * this does nothing * faster as this works * faster! * enable all * Update eng/devices/android.cake Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Rui doesn't like my yaml * flip that * this * FASTER! * FAAAAAAASTERRRRR!!!! * too fast? * 27 is just terrible * force * mac is bad sometimes * can't be const * that bad! * params can't use expressions * revert for now * no idea anymore * sigh * this * CLEANUP IS COOL * always() --------- Co-authored-by: redth <jondick@gmail.com> Co-authored-by: Jonathan Dick <jodick@microsoft.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
rmarinho
pushed a commit
that referenced
this pull request
Mar 11, 2025
…28065) * Use MSBuild for provisioning Appium and Android SDK to start * We use Nexus 5X as the device type currently * Fix provision call / logs path * Ignore exit codes NPM may not return an ok exit code if there's no appium installed. Similarly, we may get no driver list versions and a failed exit code when we query for appium drivers if none are installed. * Fix call to target * Provision JDK as well * Provision from pipeline * yaml fixes * Yaml fix * Add project to build invocation * Restore dotnet tools first * Restore tools after clear cache * Ensure winget is installed first * Download jdk msi and install it * Different download location * Property name for downloaded file * Separate provisioning steps * Log more jdk list info * Update provision.yml * Fix batching * Log msiexec install * Split up android provisioning steps * Fix indentation * Update tool with bugfix * JDK: Try default installdir on windows * Android: Option to install only default api levels * Update provision.yml * Fix parameter passing * MSBuild log diag * Skip setting JAVA_HOME * Compatible gradle versions for JDK 17 * Set JDK_HOME again * Try to pick up jdk for gradle * Fix type/var name * Always look up android home * Simplify locate of best JDK * Cake runs with stdout * Disable the cleaner as per comment * Less verbose logging * Update and comment out Tools entry point for now * Remove dup merge step * Add condition for skipping appium doctor * Skip the unsupported task * Only install the image and avd wea are using * windows or mac/linux * apples don't like linus * this too * including * better linux things * no kvm on azure * Revert "no kvm on azure" This reverts commit cdd69a3. * AndroidSdkDirectory * log the info * info * and latest * saf * Provision the JDK on linux too * sudo * list packages * remove latest * this * this * disable kvm for now * Use new emu * better things * provisioning creates the emulators * KVM * order * try this * machines * better logs * oops * cleanups * test boot * oops * test passed * try splitting * this * inside * oops * oooops * 2 * no need for menus in the build * -v:detailed * this * yaml amirite * faster! * moar! * ${{ parameters.appArtifactName }} * this * try this * that * more * ${{ parameters.platform }} * obj * oops * cake * attempt 10 million * skipDotNet * sighs * whaa * ne * oops * safdd * suspision * maybe this one? * to pwsh or not to pwsh * give up for now * test-only * log things * that * this * where is it??? * this * windows has 2 separate builds * maybe this * merge the files and jobs * this * oops * always publish * better * we can skip .net if we don't need it * names * this * try this * try again * ) * yaml is not yaml-ing * debugging yaml * eq * seems to always fail the first time * split to speed up retries * this * better * try harder * better booting and reties * this does nothing * faster as this works * faster! * enable all * Update eng/devices/android.cake Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Rui doesn't like my yaml * flip that * this * FASTER! * FAAAAAAASTERRRRR!!!! * too fast? * 27 is just terrible * force * mac is bad sometimes * can't be const * that bad! * params can't use expressions * revert for now * no idea anymore * sigh * this * CLEANUP IS COOL * always() --------- Co-authored-by: redth <jondick@gmail.com> Co-authored-by: Jonathan Dick <jodick@microsoft.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR has a bunch of things here, but they all aim to make device tests faster and prevent machine starvation.
The main changes are: