Make DisplayAlert & DisplayActionSheet more consistent by adding Async #28053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚨 API change(s) detected @davidbritch FYI |
jfversluis
force-pushed
the
net10-displayprompt-noasync
branch
2 times, most recently
from
a1e2853 to
55ed90d
Compare
jfversluis
force-pushed
the
net10-displayprompt-noasync
branch
from
55ed90d to
a38a0be
Compare
rmarinho
requested changes
Mar 18, 2025
There was a problem hiding this comment.
Seems we are missing one
D:\a\1\s\src\Core\src\Handlers\Picker\PickerHandler.iOS.cs(249,13): error CS1061: 'PickerHandler' does not contain a definition for 'DisplayAlert' and no accessible extension method 'DisplayAlert' accepting a first argument of type 'PickerHandler' could be found (are you missing a using directive or an assembly reference?) [D:\a\1\s\src\Core\src\Core.csproj::TargetFramework=net10.0-maccatalyst18.2]
github-project-automation
bot
moved this from Ready To Review
to Changes Requested
in MAUI SDK Ongoing
rmarinho
approved these changes
Mar 19, 2025
github-project-automation
bot
moved this from Ready To Review
to Approved
in MAUI SDK Ongoing
|
Failing test unrelated |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This adds the Async suffix to DisplayAlert and DisplayActionSheet to be more consistent with the rest of the codebase and following the guidelines from Microsoft. The (now) old methods, without the Async suffix, are marked as obsolete.
Issues Fixed
Fixes #6720