Update default value for LineHeight in the ToNSAttributedString method #28027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 2 out of 6 changed files in this pull request and generated no comments.
Files not reviewed (4)
- src/Controls/src/Core/PublicAPI/net-ios/PublicAPI.Shipped.txt: Language not supported
- src/Controls/src/Core/PublicAPI/net-ios/PublicAPI.Unshipped.txt: Language not supported
- src/Controls/src/Core/PublicAPI/net-maccatalyst/PublicAPI.Shipped.txt: Language not supported
- src/Controls/src/Core/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt: Language not supported
Comments suppressed due to low confidence (2)
src/Controls/src/Core/Platform/iOS/Extensions/FormattedStringExtensions.cs:36
- Ensure that the new behavior introduced by setting defaultLineHeight to -1 is adequately covered by tests.
double defaultLineHeight = -1,
src/Controls/src/Core/Platform/iOS/Extensions/FormattedStringExtensions.cs:62
- Ensure that the new behavior introduced by setting defaultLineHeight to -1 is adequately covered by tests.
double defaultLineHeight = -1,
rmarinho
requested changes
Mar 20, 2025
|
🚨 API change(s) detected @davidbritch FYI |
rmarinho
approved these changes
Mar 21, 2025
github-project-automation
bot
moved this from Changes Requested
to Approved
in MAUI SDK Ongoing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Update default value for LineHeight in the ToNSAttributedString method.
Issues Fixed
Related with #8989