-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[Android] Fix crash starting the swipe on SwipeView inside CollectionView #27669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@jsuarezruiz Since the crash is reproducing randomly on the Android platform in a Windows machine, we are unable to test the fix precisely. However, after applying the fix, the issue did not reproduce in multiple attempts. Additionally, we ensured that without the fix, the issue was reproduced in random scenarios. So, hope this PR will resolve the issue |
/rebase |
481de5a
to
ea5ac61
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Files not reviewed (1)
- src/Controls/tests/TestCases.HostApp/Issues/Issue26328.xaml: Language not supported
Comments suppressed due to low confidence (3)
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue26328.cs:17
- The test case should verify that the swipe items are correctly removed and that the crash is fixed.
[Category(UITestCategories.SwipeView)]
src/Core/src/Platform/Android/MauiSwipeView.cs:529
- Ensure that the behavior introduced by the null check for
_contentView.IsDisposed()
is covered by tests.
if (_contentView == null || _contentView.IsDisposed() || _actionView != null)
src/Core/src/Platform/Android/MauiSwipeView.cs:548
- Ensure that the behavior introduced by the null check for
swipeItem
is covered by tests.
AView? swipeItem = item?.ToPlatform(MauiContext);
…View (#27669) * Added repro sample * Added UITest * Some changes based on the issue attached log (cannot repro the issue)
Description of Change
Fix crash starting the swipe on SwipeView inside CollectionView.
I have not been able to reproduce the crash on emulators or device (Pixel 8 Android 15) so I have applied changes based on reviewing the log attached to the issue.
Draft PR until we can reproduce it.
Issues Fixed
Fixes #26328