Skip to content

Timeout Android emulator start #27657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 10, 2025
Merged

Timeout Android emulator start #27657

merged 2 commits into from
Feb 10, 2025

Conversation

PureWeen
Copy link
Member

@PureWeen PureWeen commented Feb 9, 2025

Description of Change

Occasionally the android emulator fails to start and then the process just hangs until CI just times out the pipeline

This adds code that will just fail the cake script after 2 minutes

@Copilot Copilot AI review requested due to automatic review settings February 9, 2025 21:24
@PureWeen PureWeen requested a review from a team as a code owner February 9, 2025 21:24
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

eng/devices/android.cake:457

  • Ensure that there are relevant test cases covering the new timeout behavior for the Android emulator start process.
await System.Threading.Tasks.Task.Run(() => AndroidEmulatorStart(avdName, emuSettings)).WaitAsync(TimeSpan.FromMinutes(2));

@PureWeen PureWeen force-pushed the timeout_android_device_starting branch from 3c1487a to 424f38f Compare February 9, 2025 21:33
@jsuarezruiz jsuarezruiz added the area-testing Unit tests, device tests label Feb 10, 2025
@rmarinho rmarinho merged commit 833ff0d into main Feb 10, 2025
121 of 123 checks passed
@rmarinho rmarinho deleted the timeout_android_device_starting branch February 10, 2025 13:08
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-testing Unit tests, device tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants